1340994 - Assertion failure: aSurface ? aSurfaceRect.Size() == aSurface->GetSize() : aSurfaceRect.IsEmpty(), at /FilterNodeSoftware.cpp:400

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Carsten Book [:Tomcat]]

Found via bughunter and reproduced on latest beta windows debug build from tinderbox. 

Steps to reproduce:
-> Load https://www.ibtec.com.ua/
--> Crash / Assertion 

This site also cause also problems on trunk (bug 1340992)

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to allocate a surface due to invalid size (CDT) Size(11444,11641) (t=138.054) [GFX1-]: Failed to allocate a surface due to invalid size (CDT
[GFX3-]: Surface size too large (allocation size would overflow int32_t)!
[GFX3-]: Surface size too large (allocation size would overflow int32_t)!
[GFX3-]: Surface size too large (allocation size would overflow int32_t)!
[GFX2-]: CreateDataSourceSurface failed in init
[GFX2-]: !result at c:/builds/moz2_slave/m-beta-w32-d-00000000000000000/build/src/gfx/2d/FilterProcessing.cpp:174
Assertion failure: aSurface ? aSurfaceRect.Size() == aSurface->GetSize() : aSurfaceRect.IsEmpty(), at c:/builds/moz2_slave/m-beta-w32-d-00000000000000000/build/src/gfx/2d/FilterNodeSoftware.cpp:400

Comment 1

[Carsten Book [:Tomcat]]

[Tracking Requested - why for this release]:

affects beta and aurora - Trunk is having other problems (see Bug 1340992)

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

I tested this website on different platforms, they exhibit different problems.

On Windows7, it hangs.
On Windows10, the page shows but turn to blank immediately.
On Ubuntu, it just crashes.
But it works fine on Mac.

Comment 3

[u459114]

GFX allocation failure can be fixed by the patches in bug 1336480
[GFX1-]: Failed to allocate a surface due to invalid size 

But that's not the only problem here.

Comment 4

[u459114]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #2)
> I tested this website on different platforms, they exhibit different
> problems.
> 
> On Windows7, it hangs.
> On Windows10, the page shows but turn to blank immediately.
> On Ubuntu, it just crashes.
> But it works fine on Mac.

I also load this page on chrome on windows/linux and hanged.
load it from edge, on windows 10, make my PC reboot....
safari is the only

Comment 5

[u459114]

continue...
Safari is the only one which survive

Comment 6

[u459114]

Attachment: Fix gfx allocation failure

This patch can fix gfx allocation failure.
Once can still see the follnowing log after applying this patch
[GFX3-]: Surface size too large (allocation size would overflow int32_t)!

But it's not matter, you may ignore that log.

Even we prevent gfx allocation failure, FF still can not load this page correctly.

Comment 7

[Peter Chang[:pchang]]

(In reply to Carsten Book [:Tomcat] from comment #0)
> Found via bughunter and reproduced on latest beta windows debug build from
> tinderbox. 
> 
> Steps to reproduce:
> -> Load https://www.ibtec.com.ua/
> --> Crash / Assertion 
> 
> This site also cause also problems on trunk (bug 1340992)
> 
> Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to allocate a
> surface due to invalid size (CDT) Size(11444,11641) (t=138.054) [GFX1-]:
> Failed to allocate a surface due to invalid size (CDT
> [GFX3-]: Surface size too large (allocation size would overflow int32_t)!
> [GFX3-]: Surface size too large (allocation size would overflow int32_t)!
> [GFX3-]: Surface size too large (allocation size would overflow int32_t)!
> [GFX2-]: CreateDataSourceSurface failed in init
> [GFX2-]: !result at
> c:/builds/moz2_slave/m-beta-w32-d-00000000000000000/build/src/gfx/2d/
> FilterProcessing.cpp:174
> Assertion failure: aSurface ? aSurfaceRect.Size() == aSurface->GetSize() :
> aSurfaceRect.IsEmpty(), at
> c:/builds/moz2_slave/m-beta-w32-d-00000000000000000/build/src/gfx/2d/
> FilterNodeSoftware.cpp:400

Kevin, please check anything we can do here. Maybe we need to set proper size from layout.
(In reply to Carsten Book [:Tomcat] from comment #1)
> [Tracking Requested - why for this release]:
> 
> affects beta and aurora - Trunk is having other problems (see Bug 1340992)
Tomcat, I assume we only have this problem with window debug build(Crash/Assertion) but we are fine with windows release build.

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

This website cannot be displayed properly in release, either.

The loading is very slow and only shows white page.

It even crashes chrome canary.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Sounds like that site is doing something crazy, not tracking for 52.

Comment 10

[Kevin Chen[:kechen] (UTC + 8)]

After bug 1336480 and 1340257 we won't get the assertions anymore.
The web page was tried to acquire the surface with size which exceeds our limitation periodically which make the rendering module fail to draw the content.
But the website has already updated their web page implementation and it can be loaded normally now so I mark the bug as resolved.