1341035 - Add MOZ_CrashOOL and MOZ_CrashPrintf to the prefix signature list

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

In bug 1338574 I'm adding two new variants of MOZ_CRASH, each with its own function. IIUC, these will need to be added to the prefix signature list at [1] so we don't group all crashes utilizing these functions together.

I'm not sure which way around the dependency should be here, but I'm setting this to block bug 1338574 for now.

[1] https://github.com/mozilla/socorro/blob/master/socorro/siglists/prefix_signature_re.txt

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Created a PR to do this at https://github.com/mozilla/socorro/pull/3673

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Just to be sure, you want those signatures to be part of the signature, but to always show at least the one frame that is after it, right? With your patch, that's what will happen. I ask because in 1338574#c30 you mention you want Socorro to "ignore" them, so I'd rather be sure the right thing is done. :)

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

Yeah, I think that would be ideal. Omitting them altogether probably wouldn't be bad either, but if a particular function has both regular MOZ_CRASHes and one of these, this makes them slightly easier to distinguish at a glance.

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

Though (sorry about the noise) if signature length becomes a problem, we should probably omit them instead.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Signatures get truncated at 255 bytes. I'm not sure if that knowledge helps here or not.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

If signature length becomes a problem, we can file a new bug and find solutions. For now, let's just proceed with this. 

https://github.com/mozilla/socorro/commit/19efcc961c69cbc9095cdf2dad41c89f4033f628

Comment 7

[Emanuel Hoogeveen [:ehoogeveen]]

Great, thanks!