Closed Bug 1341036 Opened 4 years ago Closed 4 years ago

Remove fallback styling from dropmarker.css on macOS

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: dao, Assigned: deepsrijit1105, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

first_patch
1.56 KB, patch
dao
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1340626 +++

Bug 1340626 removed the fallback border and background styling from dropmarker.css on Windows (toolkit/themes/windows/global/dropmarker.css). We should do the same on Mac (toolkit/themes/osx/global/dropmarker.css).
Blocks: 1341048
Summary: Remove fallback styling from dropmarker.css → Remove fallback styling from dropmarker.css on macOS
Hey I was wondering if I could work on this bug?
(In reply to irish.l.jack from comment #1)
> Hey I was wondering if I could work on this bug?

Sure!
Attached patch first_patch — — Splinter Review 
Hi Dao,

I have attached a patch for this bug. Let me know if any changes are required.

Thanks.
Attachment #8839637 - Flags: review?(dao+bmo)
Comment on attachment 8839637 [details] [diff] [review]
first_patch

Looks good!

Side note: It seems a little bit rude to take this bug shortly after somebody else said they wanted to work on it. :/
Attachment #8839637 - Flags: review?(dao+bmo) → review+
Assignee: nobody → deepsrijit1105
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33e3fa0ddfc2
Remove fallback styling from dropmarker.css. r=dao
Oh sorry Dão, I came to a notion that if no one is assigned a bug, the person who submits the first patch is assigned. Sorry again, I will not do it again.
Flags: needinfo?(dao+bmo)
https://hg.mozilla.org/mozilla-central/rev/33e3fa0ddfc2
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(In reply to Deepa from comment #6)
> Oh sorry Dão, I came to a notion that if no one is assigned a bug, the
> person who submits the first patch is assigned. Sorry again, I will not do
> it again.

Alright! Let's hope irish.l.jack finds another bug to work on.
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.