1341038 - No notification of success/failure is displayed when deleting a login

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: HTC 10 (Android 6.0.1);
Build: Nightly 54.0a1 (2017-02-19);

Prerequisite: perform a sync.

Steps to reproduce:
1. Go to Menu -> Tools -> Logins;
2. Choose one login entry and tap on it;
3. Choose 'Delete' and confirm the deletion.

Expected result:
A notification/snack-bar is displayed informing the user that login was deleted.

Actual result:
No notification/snack-bar is displayed.

Notes:
For the rest of available option: show password, copy password, copy username, edit login when user make an action, a notification is displayed.

Comment 1

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.

Comment 2

[Jing-wei Wu [:jwu]]

It shouldn't be hard to show a snack bar when delete a login record, I would try to send a patch for this.

Comment 3

[Jing-wei Wu [:jwu]]

Attachment: Bug 1341038 - Show snackbar for notification when delete a login record.

Review commit: https://reviewboard.mozilla.org/r/182522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182522/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8911049 [details]
Bug 1341038 - Show snackbar for notification when delete a login record.

https://reviewboard.mozilla.org/r/182522/#review188104

Comment 5

[Julian Chu [:walkingice]]

Comment on attachment 8911049 [details]
Bug 1341038 - Show snackbar for notification when delete a login record.

https://reviewboard.mozilla.org/r/182522/#review193982

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41debb5cecaf
Show snackbar for notification when delete a login record. r=nechen,walkingice

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/41debb5cecaf

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed in build 58.0a1 (10-13);
Device: Huawei P9 Lite(Android 6.0).