134106 - Uppercase (IMAGE) Content-Type causes Netscape to fail decoding an image attachment

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Trix Supremo]

Description:
Netscape6.x does not decode an image attachment if the Content-Type is
uppercase, ie., "IMAGE/gif"

REPRODUCIBLE: 
Always

STEPS:
1. Send a message containing a GIF image attachment to yourself.
2. Save that message to your desktop and name it "message.eml"
3. With a text editor. open MESSAGE.EML and change the Content-Type from
"image/gif" to "IMAGE/gif".
4. Save the new message as "message_new.eml"
5. Compose a new message to yourself and attach MESSAGE_NEW.EML and send it.
6. Now select that message from your Inbox.

RESULTS:
The GIF attachment is no longer displayed inline or as an image in the
attachment box.(FYI: if you attach the original message MESSAGE.EML and send to
yourself, you'll see that the image is displayed in the attachment window and
inline as well).

NOTES:
Email clients like PINE capitalize most encoding descriptions like Content-Type.
Thus Netscape fails to decode image attachments sent from clients that encode
attachments using an uppercase description. 

This problem seems to be isolated to the IMAGE Content-type only.  Verified that
application/ or text/ when capitalized are still able to be decoded properly.
Also, the file extension "GIF" or "gif" does not cause the problem either.

ATTACHED:
Attached to this bug are 2 email messages, MESSAGE.EML was the original email
message which shows the problem, and MESSAGE_NEW.EML is the same message but the
IMAGE Content-Type has been changed to lowercase. 

If you attach the original MESSAGE.EML to a message and send to yourself, you'll
notice that 2 image files are not decoded and displayed.  If you attach the
revised email MESSAGE_NEW.EML to a message and send, you'll notice that the 2
image files are now displayed and properly decoded.

Comment 1

[Trix Supremo]

Attachment: wrong file don't use

Comment 2

[Trix Supremo]

Attachment: wrong file don't use

Comment 3

[Trix Supremo]

nominating to nsbeta1

Comment 4

[Trix Supremo]

Attachment: Email message containing image attachment with Content-Type "image" in lowercase

Comment 5

[Trix Supremo]

Attachment: Test email message containing image attachment with Content-Type "IMAGE" in uppercase

Comment 6

[Jean-Francois Ducarroz]

I checked the mime code and it's not dependent on the capitalization of the
content-type. But mime ask the imageLoader if it support the content-type. My
guess is that the image loader expect a lowercase content-type!

Comment 7

[Jean-Francois Ducarroz]

*** Bug 133941 has been marked as a duplicate of this bug. ***

Comment 8

[Jean-Francois Ducarroz]

this is a recent regression caused by fix for bug 104906. Christian, Pav, can we
make SupportImageWithMimeType not case sensitive whit the content type?

Comment 9

[Boris Zbarsky [:bzbarsky]]

nsCAutoString 
  decoderId(NS_LITERAL_CSTRING("@mozilla.org/image/decoder;2?type=") +
            nsDependentCString(aMimeType));

is going to need to change into

nsCAutoString mimeType(aMimeType);
ToLowerCase(mimeType);
nsCAutoString 
  decoderId(NS_LITERAL_CSTRING("@mozilla.org/image/decoder;2?type=") +
            mimeType);

or something along those lines....

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

sorry, I forgot that I had to lowercase the name...

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

eh, of course, s/name/mimetype

pavlov, can you review this patch?
it fixes a regression

Comment 12

[Jean-Francois Ducarroz]

reassign to [e-mail]

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

taking, and changing component to browser/imagelib where it belongs

Comment 14

[Stuart Parmenter]

Comment on attachment 76736 [details] [diff] [review]
patch

r=pavlov

Comment 15

[tor]

Comment on attachment 76736 [details] [diff] [review]
patch

sr=tor

Comment 16

[Vincent Jaubert]

Could it be related to bug #131618 ?

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

not related to bug 131618. the image type there is already lowercase.
furthermore it didn't work in NS 4.x either.

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 76736 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 20

[Trix Supremo]

verified on trunk build 2002042512-trunk & branch build 2002042508-1.0.0