Closed Bug 1341089 Opened 3 years ago Closed 3 years ago

devtools.network.onNavigated should be fired when the target page has been navigated

Categories

(WebExtensions :: Developer Tools, defect, P1)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Iteration:
54.3 - Mar 6
Tracking Status
firefox54 --- fixed

People

(Reporter: rpl, Assigned: rpl)

References

(Regressed 1 open bug)

Details

(Whiteboard: [devtools][devtools.network] triaged)

Attachments

(1 file)

This issue is a follow up of Bug 1300588 (which introduced the devtools.network.onNavigated event):

Currently the onNavigated event is fired when the target page is starting a navigation (e.g. reloading the current url or loading a new url), because the event implementation currently subscribe the internal Firefox DevTools "will-navigate" event.

Unfortunately this turned out to be the wrong time to fire this event:

the existent devtools addons that are using this API are often using the devtools.inspectedWindow.eval API method to inject javascript code in the target page, e.g. like the the ember-inspector does here:

https://github.com/emberjs/ember-inspector/blob/master/app/adapters/chrome.js#L47-L50

which is supposed to happen just after the target page has been navigated (which should correspond to the internal Firefox DevTools "navigate" event, instead of the current subscribed "will-navigate" event).
Attachment #8839219 - Flags: review?(kmaglione+bmo)
Assignee: nobody → lgreco
Blocks: 1211859
Status: NEW → ASSIGNED
Iteration: --- → 54.3 - Mar 6
Priority: -- → P1
Whiteboard: [devtools][devtools.network] triaged
Comment on attachment 8839219 [details]
Bug 1341089 - devtools.network.onNavigated should be fired when the target page has been navigated.

https://reviewboard.mozilla.org/r/113918/#review118890
Attachment #8839219 - Flags: review?(kmaglione+bmo) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/625d277367c3
devtools.network.onNavigated should be fired when the target page has been navigated. r=kmag
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/625d277367c3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Toolkit → WebExtensions
Regressions: 1552686
You need to log in before you can comment on or make changes to this bug.