Closed
Bug 1341089
Opened 7 years ago
Closed 7 years ago
devtools.network.onNavigated should be fired when the target page has been navigated
Categories
(WebExtensions :: Developer Tools, defect, P1)
WebExtensions
Developer Tools
Tracking
(firefox54 fixed)
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
(Regressed 1 open bug)
Details
(Whiteboard: [devtools][devtools.network] triaged)
Attachments
(1 file)
This issue is a follow up of Bug 1300588 (which introduced the devtools.network.onNavigated event): Currently the onNavigated event is fired when the target page is starting a navigation (e.g. reloading the current url or loading a new url), because the event implementation currently subscribe the internal Firefox DevTools "will-navigate" event. Unfortunately this turned out to be the wrong time to fire this event: the existent devtools addons that are using this API are often using the devtools.inspectedWindow.eval API method to inject javascript code in the target page, e.g. like the the ember-inspector does here: https://github.com/emberjs/ember-inspector/blob/master/app/adapters/chrome.js#L47-L50 which is supposed to happen just after the target page has been navigated (which should correspond to the internal Firefox DevTools "navigate" event, instead of the current subscribed "will-navigate" event).
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8839219 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → lgreco
Blocks: 1211859
Status: NEW → ASSIGNED
Iteration: --- → 54.3 - Mar 6
Priority: -- → P1
Whiteboard: [devtools][devtools.network] triaged
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8839219 [details] Bug 1341089 - devtools.network.onNavigated should be fired when the target page has been navigated. https://reviewboard.mozilla.org/r/113918/#review118890
Attachment #8839219 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/625d277367c3 devtools.network.onNavigated should be fired when the target page has been navigated. r=kmag
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/625d277367c3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•