Closed
Bug 1341094
Opened 7 years ago
Closed 7 years ago
Avoid using jsapi for mozILocaleService.getAppLocales
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jfkthame, Unassigned)
References
Details
Attachments
(1 file)
3.12 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In bug 1336281 comment 28, :smaug advised against using jsapi here. Looks like we can easily update the IDL declaration and the underlying C++ implementation to avoid this, without changing how JS code will use the method.
Reporter | ||
Comment 1•7 years ago
|
||
Something like this should work, AFAICS. JS callers shouldn't see any difference.
Attachment #8839226 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8839226 -
Flags: review?(bugs) → review+
Reporter | ||
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3910a1fa01c05b40a024e7d12857d0300004c8ae Bug 1341094 - Update mozILocaleService.getAppLocales to avoid use of jsapi. r=smaug
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3910a1fa01c0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•