Rename Log() in WidevineUtils.h to CDM_LOG

RESOLVED FIXED in Firefox 54

Status

()

Core
Audio/Video: GMP
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I sometimes get a compile error when the unified build groupings change due to the Log macro in WidevineUtils.h being used to substitute out the Log function in IPC's ParamTraits classes defined in GMPMessageUtils.h.

So we should rename the Log macro to something that it unlikely to clash.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8839286 [details]
Bug 1341135 - Rename CDM log macro from Log to CDM_LOG.

https://reviewboard.mozilla.org/r/113964/#review115496
Attachment #8839286 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

a year ago
mozreview-review
Comment on attachment 8839286 [details]
Bug 1341135 - Rename CDM log macro from Log to CDM_LOG.

https://reviewboard.mozilla.org/r/113964/#review115498
Attachment #8839286 - Flags: review+

Comment 4

a year ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f04fef720ec
Rename CDM log macro from Log to CDM_LOG. r=gerald

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f04fef720ec
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.