Closed Bug 1341174 Opened 3 years ago Closed 3 years ago

Bring the declarations of the four Draw*Image() methods in nsLayoutUtils.h back together

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

Over time the declarations of the four Draw*Image() methods in nsLayoutUtils.h have become separated by declarations of unrelated methods. This makes it harder for new people to notice the various options, or that they exist as a set, and it makes the comments that proceed them make less sense.
Attached patch patchSplinter Review
Attachment #8839307 - Flags: review?(dholbert)
Comment on attachment 8839307 [details] [diff] [review]
patch

Review of attachment 8839307 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=me
Attachment #8839307 - Flags: review?(dholbert) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76c47a2fe8c5
Bring the declarations of the four Draw*Image() methods in nsLayoutUtils.h back together. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/76c47a2fe8c5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.