1341206 - Crash in mozilla::dom::cache::db::`anonymous namespace''::Migrate

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ting-Yu Chou [:ting] (away)]

This bug was filed from the Socorro interface and is 
report bp-a375191c-347c-4083-94f6-ca65d2170221.
=============================================================
Top #8 of Aurora 20170219004014 on Windows, 15 crashes from 3 installations.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This reflects profiles being shared between nightly and aurora with incompatible cache schema versions.  We could switch this back to a MOZ_ASSERT() since we also catch this condition and refuse to open storage.

Do you mind trying this?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Actually, I'm just going to go ahead and do this.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Relax Cache API schema version assertion since mismatches can happen in release profiles. r=asuth

Lets not crash release builds if they get a cache schema version mismatch.  Our runtime checking will handle this.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

This only affects nightly/aurora because its a MOZ_DIAGNOSTIC_ASSERT.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ebff6b4a913
Relax Cache API schema version assertion since mismatches can happen in release profiles. r=asuth

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8839483 [details] [diff] [review]
Relax Cache API schema version assertion since mismatches can happen in release profiles. r=asuth

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1328686 converted a MOZ_ASSERT() into a MOZ_DIAGNOSTIC_ASSERT().
[User impact if declined]: Crashes when a user shared a profile across firefox channels with different Cache API schema versions.  Normally we just refuse to open the storage system instead of crashing.
[Is this code covered by automated tests?]: This kind of version mismatch is not tested as far as I know.
[Has the fix been verified in Nightly?]: No.  The schema version mismatch is really only triggered on aurora when it opens a profile that was upgraded to nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No risk.
[Why is the change risky/not risky?]: The patch simply converts a MOZ_DIAGNOSTIC_ASSERT() back to a MOZ_ASSERT().  We had this exact code for a long time before bug 1328686 changed it recently.
[String changes made/needed]: None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ebff6b4a913

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8839483 [details] [diff] [review]
Relax Cache API schema version assertion since mismatches can happen in release profiles. r=asuth

Fix a crash. Aurora53+.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/e87493254cbe0c4e91e84ecb57f56d162c187c8c