Closed
Bug 1341215
Opened 7 years ago
Closed 7 years ago
Avoid requiring a virtualenv for mach artifact
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(3 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8839360 [details] Bug 1341215 - Vendor dlmanager. https://reviewboard.mozilla.org/r/114040/#review116216 Can we just vendor mozregression? I think there's a mach command that would end up using it as well. Can we at least drop a link to the origin of this code in a comment at the top of each file?
Attachment #8839360 -
Flags: review?(cmanchester) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8839360 [details] Bug 1341215 - Vendor dlmanager. https://reviewboard.mozilla.org/r/114040/#review116218 Meant to cancel review for now. Copying these files from github (one of which doesn't have a license header) without making their origin clearer doesn't seem quite right.
Attachment #8839360 -
Flags: review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8839361 [details] Bug 1341215 - Remove the dependency on the mozregression module for mach artifact. https://reviewboard.mozilla.org/r/114042/#review116220 Thanks for the patches, this is a very welcome simplification.
Attachment #8839361 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #3) > Comment on attachment 8839360 [details] > Bug 1341215 - Remove the dependency on the mozregression module for mach > artifact. > > https://reviewboard.mozilla.org/r/114040/#review116216 > > Can we just vendor mozregression? I think there's a mach command that would > end up using it as well. Vendoring mozregression would need vendoring at least BeautifulSoup, taskcluster, mohawk and colorama. That's too much for my taste. > Can we at least drop a link to the origin of this code in a comment at the > top of each file? Sure, but looking deeper in all that, there needs to be some clarification about the license first :-/ Will file an issue on github.
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #6) > Will file an issue on github. Aha, issues are not enabled on github ; it looks like bugzilla is the place to file bugs for it.
Assignee | ||
Comment 8•7 years ago
|
||
It turns out the download manager part is also available separately on https://github.com/parkouss/dlmanager and only requires requests and six. We have both in the tree already, although six is in a weird location (testing/web-platform/tests/tools/six).
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8839360 [details] Bug 1341215 - Vendor dlmanager. https://reviewboard.mozilla.org/r/114040/#review116514
Attachment #8839360 -
Flags: review?(cmanchester) → review+
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8840307 [details] Bug 1341215 - Remove the dependency on the python taskcluster client module for `mach artifact`. https://reviewboard.mozilla.org/r/114806/#review116516
Attachment #8840307 -
Flags: review?(cmanchester) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•7 years ago
|
||
(Pushed reordered commits, no changes ; waiting for dependent bugs to land before landing this)
Comment 18•7 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/7d817a123f53 Vendor dlmanager. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/4f108fc57f7c Remove the dependency on the mozregression module for mach artifact. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/f967d32a9efb Remove the dependency on the python taskcluster client module for `mach artifact`. r=chmanchester
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d817a123f53 https://hg.mozilla.org/mozilla-central/rev/4f108fc57f7c https://hg.mozilla.org/mozilla-central/rev/f967d32a9efb
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•