1341227 - [Mac] Hover Feedback not aligned with zoom buttons separator

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Attachment: Screencast showing the issue

[Affected versions]:
- Firefox 51.0.1
- Firefox 52.0b8
- latest Developer Edition 53.0a2
- latest Nightly 54.0a1

[Affected platforms]:
- macOS 10.12.3
- Mac OS X 10.11.6

[Steps to reproduce]:
1. Start Firefox
2. Enter Customization and drag the zoom buttons to ToolBar
3. Hover over zoom buttons and focus the separator between Zoom Out and Reset.

[Expected result]:
- The hover feedback is aligned with buttons separator.

[Actual result]:
- Hover feedback is aligned with separator of buttons (|Zoom out|Reset|Zoom in|)

[Regression range]:
- This is NOT a recent regression (but a very old one), I've tracked it back to Nightly from 2014-01-18:

Last good revision: 8122ffa9e1aa (2014-03-06)
First bad revision: b0e7f63c2138 (2014-03-07)

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8122ffa9e1aa&tochange=b0e7f63c2138

There are a few bugs there, not sure which one is the cause of this. 

[Additional notes]:
- The GOOD build is a build without hover feedback and at some point during the regression search the same issue was seen on the separator between Reset and Zoom In.
-

Comment 1

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> - This is NOT a recent regression (but a very old one), I've tracked it back
> to Nightly from 2014-01-18:

This date is actually incorrect, it's actually 2014-03-07. (bad copy paste)

Comment 2

[Gerry Chang [:gchang]]

This is not a regression and it's been there for a while. Mark 51 won't fix.

Comment 3

[Dão Gottwald [::dao]]

Bug 1352364 probably improved this. Mac shouldn't be different from Windows anymore.

Comment 4

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

(In reply to Dão Gottwald [::dao] from comment #3)
> Bug 1352364 probably improved this. Mac shouldn't be different from Windows
> anymore.

Yep, I can't see this issue anymore using latest Nightly build on macOS 10.12.4 and Mac OS X 10.10.5. I'll go ahead and mark this as Worksforme.