Move mozcontainer.c to cpp file

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stransky, Unassigned)

Tracking

Trunk
mozilla54
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
To use libwayland-client wrapper from Bug 1299083 we would need to move mozcontainer to cpp code. We may also move gtk2drawing if necessary.
(Reporter)

Updated

2 years ago
Severity: minor → normal
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8839501 [details]
Bug 1341296 - Move mozcontainer.c to cpp file,

https://reviewboard.mozilla.org/r/114120/#review115730

Thanks!

::: widget/gtk/mozcontainer.cpp:93
(Diff revision 1)
>  GtkWidget *
>  moz_container_new (void)
>  {
>      MozContainer *container;
>  
> -    container = g_object_new (MOZ_CONTAINER_TYPE, NULL);
> +    container = static_cast<MozContainer*>(g_object_new (MOZ_CONTAINER_TYPE, NULL));

Please change to nullptr here.

C++ NULL differs from C NULL and is not necessarily safe to use when the callee expects a pointer sentinel.

https://ewontfix.com/11/
Attachment #8839501 - Flags: review?(karlt) → review+
Comment hidden (mozreview-request)
(Reporter)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6c746c1306a2
Move mozcontainer.c to cpp file, r=karlt
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6c746c1306a2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.