Intermittent browser/base/content/test/webextensions/browser_extension_update_background.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

RESOLVED FIXED in Firefox 55

Status

WebExtensions
General
RESOLVED FIXED
a year ago
2 days ago

People

(Reporter: Treeherder Bug Filer, Assigned: gbrown)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {intermittent-failure})

unspecified
mozilla55
intermittent-failure
Dependency tree / graph

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment 1

a year ago
6 failures in 812 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 4
* autoland: 2

Platform breakdown:
* linux32: 5
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-02-20&endday=2017-02-26&tree=all

Comment 2

a year ago
10 failures in 777 pushes (0.013 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 5
* autoland: 2
* try: 1
* oak: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 5
* linux32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-03-13&endday=2017-03-19&tree=all

Comment 3

a year ago
9 failures in 898 pushes (0.01 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 5
* autoland: 3
* try: 1

Platform breakdown:
* linux64: 7
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-03-20&endday=2017-03-26&tree=all

Comment 4

a year ago
19 failures in 123 pushes (0.154 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 9
* mozilla-central: 7
* mozilla-inbound: 3

Platform breakdown:
* linux64: 14
* linux32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-03-30&endday=2017-03-30&tree=all
(Assignee)

Updated

a year ago
Assignee: nobody → gbrown
(Assignee)

Comment 5

a year ago
There have been infrequent failures in this bug for the last month, but frequency spiked alarmingly yesterday. The test was recently updated in bug 1344665.

Recent logs show the test progressing just before the timeout, suggesting the test would pass with a longer timeout.

Failures are all Linux and mostly Debug.

:aswan - Can you have a look right away? This failure looks very frequent now. Do you want to optimize or split the test, or just increase the timeout?
Assignee: gbrown → nobody
Blocks: 1344665
Component: General → WebExtensions: General
Flags: needinfo?(aswan)
Product: Firefox → Toolkit
Summary: Intermittent browser/base/content/test/general/browser_extension_update_background.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Intermittent browser/base/content/test/webextensions/browser_extension_update_background.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Whiteboard: [stockwell needswork]
(Assignee)

Comment 6

a year ago
Test durations for browser/base/content/test/webextensions/browser_extension_update_background.js on mozilla-central,mozilla-inbound,autoland between 2017-03-14 and 2017-03-28
linux32-nightly/opt-chunked:    16.25 s (12.48 s - 21.01 s over 24 runs)
linux32-nightly/opt-e10s:       17.66 s (15.35 s - 21.01 s over 11 runs)
linux32/debug-chunked:          76.03 s (56.93 s - 90.63 s over 885 runs)
linux32/debug-e10s:             80.14 s (60.71 s - 90.56 s over 350 runs)
linux32/opt-chunked:            19.55 s (14.07 s - 44.80 s over 1027 runs)
linux32/opt-e10s:               21.04 s (15.03 s - 27.72 s over 354 runs)
linux64-ccov/opt-chunked:        8.36 s (8.01 s - 9.12 s over 10 runs)
linux64-jsdcov/opt:             11.47 s (10.91 s - 12.05 s over 10 runs)
linux64-nightly/opt-chunked:    16.27 s (11.29 s - 19.69 s over 23 runs)
linux64-nightly/opt-e10s:       17.30 s (15.60 s - 19.69 s over 11 runs)
linux64/asan-chunked:           39.55 s (28.39 s - 74.32 s over 882 runs)
linux64/asan-e10s:              41.56 s (30.78 s - 67.78 s over 400 runs)
linux64/debug-chunked:          77.90 s (57.85 s - 90.43 s over 792 runs)
linux64/debug-e10s:             81.34 s (59.66 s - 90.43 s over 492 runs)
linux64/opt-chunked:            19.08 s (13.90 s - 44.66 s over 601 runs)
linux64/opt-e10s:               20.19 s (14.33 s - 44.66 s over 303 runs)
linux64/pgo-chunked:            16.80 s (10.84 s - 27.13 s over 729 runs)
linux64/pgo-e10s:               17.32 s (11.55 s - 27.13 s over 431 runs)

It looks like this test was often running for 75 to 80 seconds on linux32/64-debug before bug 1344665 - it wouldn't take much delay to start hitting the 90 second timeout.

Comment 7

a year ago
79 failures in 146 pushes (0.541 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 32
* autoland: 32
* try: 7
* mozilla-central: 4
* oak: 2
* graphics: 2

Platform breakdown:
* linux64: 53
* linux32: 26

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-03-31&endday=2017-03-31&tree=all
Comment hidden (mozreview-request)
Kris, I'm about to go offline for a week but this test is failing so frequently that this should get dealt with soon.  Can you review the attached patch and just go ahead and land it if it looks okay?
Flags: needinfo?(aswan) → needinfo?(kmaglione+bmo)

Comment 10

a year ago
mozreview-review
Comment on attachment 8853615 [details]
Bug 1341337 Break up browser_update_background.js

https://reviewboard.mozilla.org/r/125706/#review128256
Attachment #8853615 - Flags: review+

Comment 11

a year ago
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f5ed86994ee4
Break up browser_update_background.js r=kmag
https://hg.mozilla.org/mozilla-central/rev/f5ed86994ee4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → aswan
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → affected
status-firefox-esr52: --- → unaffected
status-firefox54: affected → wontfix
(Assignee)

Comment 13

a year ago
Andrew, thanks so much for your efforts here, especially right before pto!

Unfortunately, something has gone wrong. This bug is about browser_extension_update_background.js, not browser_update_background.js (referenced by patch comment) and not browser_update_interactive.js (actually split).

browser_extension_update_background.js is still failing very frequently.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
35 failures in 51 pushes (0.686 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 14
* mozilla-central: 11
* autoland: 8
* try: 2

Platform breakdown:
* linux64: 22
* linux32: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-04-01&endday=2017-04-01&tree=all
172 failures in 845 pushes (0.204 failures/push) were associated with this bug in the last 7 days. 

This is the #5 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 70
* mozilla-inbound: 54
* mozilla-central: 29
* try: 14
* oak: 2
* graphics: 2
* mozilla-aurora: 1

Platform breakdown:
* linux64: 118
* linux32: 54

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-03-27&endday=2017-04-02&tree=all
(Assignee)

Updated

a year ago
Assignee: aswan → gbrown
Flags: needinfo?(kmaglione+bmo)
(Assignee)

Comment 16

a year ago
Created attachment 8854071 [details] [diff] [review]
Break up browser_extension_update_background.js

I'm not familiar with this test, but it is failing so frequently, I want to make sure we do something about it today, and this seems like a natural way to split it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eafb5575c4d118a678d2b171e6b7ad710fd32aaf
Attachment #8854071 - Flags: review?(kmaglione+bmo)
Attachment #8854071 - Flags: review?(kmaglione+bmo) → review+

Comment 17

a year ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/284cf846989b
Split test browser_extension_update_background.js; r=kmag
65 failures in 147 pushes (0.442 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 24
* mozilla-inbound: 21
* try: 9
* mozilla-central: 7
* oak: 2
* graphics: 2

Platform breakdown:
* linux64: 36
* linux32: 29

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-04-03&endday=2017-04-03&tree=all
(Assignee)

Updated

a year ago
Whiteboard: [stockwell needswork] → [stockwell fixed]

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/284cf846989b
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
108 failures in 867 pushes (0.125 failures/push) were associated with this bug in the last 7 days. 

This is the #11 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 44
* mozilla-inbound: 33
* try: 12
* mozilla-central: 12
* oak: 4
* graphics: 2
* mozilla-aurora: 1

Platform breakdown:
* linux64: 63
* linux32: 44
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341337&startday=2017-04-03&endday=2017-04-09&tree=all
(Assignee)

Updated

a year ago
Depends on: 1354415

Updated

2 days ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.