Closed
Bug 1341361
Opened 7 years ago
Closed 7 years ago
Fix race conditions for list change listeners in root actor
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Follow-up to Bug 1304941. In devtools root actor, all on{Something}Changed methods can miss updates due to a race condition. This was fixed for onTabListChanged in Bug 1304941. The purpose of this bug is to fix the other methods as well: - onAddonListChanged - onWorkerListChanged - onServiceWorkerRegistrationListChanged (onProcessListChanged is not impacted by the issue)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5749b9525898de871320b4de2b790e7a6ec79c1c
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8839568 [details] Bug 1341361 - reattach listChanged evts in root actor earlier to avoid missing updates; https://reviewboard.mozilla.org/r/114160/#review116120 Looks good, thanks for working on it!
Attachment #8839568 -
Flags: review?(jryans) → review+
Comment hidden (mozreview-request) |
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a3b2705a431 reattach listChanged evts in root actor earlier to avoid missing updates;r=jryans
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a3b2705a431
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•