HashTable::Ptr::isValid returns the opposite of what you expect

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 months ago
5 months ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Back in bug 1260785 I renamed the the 'error' method I added to 'isValid' as suggested in the code review comments but I didn't invert the return value.
(Assignee)

Comment 1

5 months ago
Created attachment 8874464 [details] [diff] [review]
bug1341367-hashtable-ptr-valid

Patch to invert the return value of isValid() to match its name and update callers.
Assignee: nobody → jcoppeard
Attachment #8874464 - Flags: review?(luke)

Updated

5 months ago
Attachment #8874464 - Flags: review?(luke) → review+

Comment 2

5 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/711a50eff7d8
Make the sense of HashTable::Ptr::isValid match its name r=luke

Comment 3

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/711a50eff7d8
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.