Closed Bug 1341367 Opened 3 years ago Closed 3 years ago

HashTable::Ptr::isValid returns the opposite of what you expect

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Back in bug 1260785 I renamed the the 'error' method I added to 'isValid' as suggested in the code review comments but I didn't invert the return value.
Patch to invert the return value of isValid() to match its name and update callers.
Assignee: nobody → jcoppeard
Attachment #8874464 - Flags: review?(luke)
Attachment #8874464 - Flags: review?(luke) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/711a50eff7d8
Make the sense of HashTable::Ptr::isValid match its name r=luke
https://hg.mozilla.org/mozilla-central/rev/711a50eff7d8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.