Closed
Bug 1341370
Opened 7 years ago
Closed 7 years ago
No "Previous Conversations" tree shown
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 54.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
7.73 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
With today Daily (20170221) in Chat tab the "Previous Conversations" tree isn't shown Last good is daily 20170210. When I log in I get following error: A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Date: Tue Feb 21 2017 18:44:50 GMT+0100 Full Message: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIStringBundle.GetStringFromName] Full Stack: JS frame :: XStringBundle :: getString :: line 22 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: formatMonth :: line 1249 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: formatMonthYear :: line 1244 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: cLTV__rebuild :: line 1318 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: chatLogTreeView :: line 1212 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: _showLogList :: line 489 JS frame :: chrome://messenger/content/chat/chat-messenger-overlay.js :: onListItemSelected/< :: line 693 JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: process :: line 922 JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: walkerLoop :: line 806 XStringBundle:22
Assignee | ||
Comment 1•7 years ago
|
||
Backout of bug 1225696 fixes the issue.
Assignee | ||
Comment 2•7 years ago
|
||
Bug 1225696 removed the dateFormat.properties. I added them in chat back. It's a full copy of the toolkit file, with addition of "finduri-MonthYear" which was removed too. Maybe not all strings are used. If you like I can check and remove the unused strings.
Comment 3•7 years ago
|
||
Comment on attachment 8839884 [details] [diff] [review] Bug1341370.patch Review of attachment 8839884 [details] [diff] [review]: ----------------------------------------------------------------- Awesome. Thanks!
Attachment #8839884 -
Flags: review?(clokep) → review+
Comment 4•7 years ago
|
||
Looking briefly at the bug 1225696, I don't think we can just make similar changes to that, right? Those all seem to be in C++...
Assignee | ||
Comment 5•7 years ago
|
||
It could maybe be done but I'm the totally wrong person for that to try this.
Keywords: checkin-needed
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b3cdf98b16ef062856ad86526c8635e5eff27ac6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in
before you can comment on or make changes to this bug.
Description
•