Closed Bug 1341390 Opened 4 years ago Closed 2 years ago
Ensure dom/tests/js and dom/tests/html are covered by automated tests and then delete them
I cannot find reference in-tree to js/ or html/ being used or mentioned. Can we get a readme file to indicate why these exist, or just delete these files?
:overholt, can you help determine what these directories/files are used for? hg history shows the cvs import from 2007 as all changes (other than wide sweeping mass changes)
I see no references, either. Comments like Boris' in bug 345521 comment 8 seem to back this up. Let's confirm with Boris.
Flags: needinfo?(overholt) → needinfo?(bzbarsky)
These are manual tests, afaict. We could try ensuring that they're ported to one of our automated suites when possible, then delete them.
Priority: -- → P5
Summary: dom/tests/js and dom/tests/html do not appear to be used at all → Ensure dom/tests/js and dom/tests/html are covered by automated tests and then delete them
Attachment #9017120 - Flags: review?(bzbarsky)
> Covered by: `dom/nodes/Node-properties.html`. What dom/tests/js/class.html is really testing is that the class change triggers restyling and relayout. The dom/nodes/Node-properties.html wpt doesn't test that, but I'm pretty sure other wpts do. > Tests `getElementById()`. No, tests that changing the id does restyling and relayout. Again probably covered by wpts, but not by `dom/nodes/Document-getElementById.html
Comment on attachment 9017120 [details] [diff] [review] Remove-unused-tests-dom-tests-html-and-dom-tests-js.patch r=me. Thank you for the patch and the analysis! It's very much appreciated.
Attachment #9017120 - Flags: review?(bzbarsky) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/357559d3ec0d Remove unused tests dom/tests/html and dom/tests/js. r=bzbarsky
You need to log in before you can comment on or make changes to this bug.