Closed
Bug 1341441
Opened 6 years ago
Closed 6 years ago
GMPVideoDecoderParent.cpp should include nsPrintfCString.h
Categories
(Core :: Audio/Video: GMP, defect, P3)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(1 file)
GMPVideoDecoderParent.cpp uses nsPrintfCString but doesn't include nsPrintfCString.h. The build only works because of unified builds and this file is normally compiled with other things that include nsPrintfCString.h. If I add files to the build in dom/media/gmp, I often break the build due to this.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8839690 [details] Bug 1341441 - Include nsPrintfCString in GMPVideoDecoderParent.cpp. https://reviewboard.mozilla.org/r/114270/#review115702
Attachment #8839690 -
Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77099fee3aa9 Include nsPrintfCString in GMPVideoDecoderParent.cpp. r=gerald
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/77099fee3aa9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•