1341450 - Running mochitests with DMD enabled fails

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

End of output looks like this:

MEMORY STAT | vsize 1352MB | residentFast 146MB | heapAllocated 39MB
/tests/dom/canvas/test/crash/test_1251091-1.html | DMD-DUMP-deprecated /home/kats/tmp/dmd/dmd-0-deprecated.txt
JavaScript error: http://mochi.test:8888/tests/SimpleTest/MemoryStats.js, line 112: ReferenceError: DMDReportAndDump is not defined

I think this is because the typeof check at http://searchfox.org/mozilla-central/rev/12cf11303392edac9f1da0c02e3d9ad2ecc8f4d3/testing/mochitest/tests/SimpleTest/MemoryStats.js#107 is passing because "undefined" (the string, returned by typeof) is not equal to |undefined| (the JS primitive, on the RHS of the condition).

I'll have a patch up once I verify the fix.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1341450 - Repair incorrect check for missing DMDReportAndDump function.

Review commit: https://reviewboard.mozilla.org/r/114314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114314/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

This fixes the error in comment 0 but it doesn't seem to actually get DMD working. I'm still investigating, but this patch should probably land regardless.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8839743 [details]
Bug 1341450 - Repair incorrect check for missing DMDReportAndDump function.

https://reviewboard.mozilla.org/r/114314/#review115770

good find!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0894bd95e396
Repair incorrect check for missing DMDReportAndDump function. r=jmaher

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0894bd95e396