Running mochitests with DMD enabled fails

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

End of output looks like this:

MEMORY STAT | vsize 1352MB | residentFast 146MB | heapAllocated 39MB
/tests/dom/canvas/test/crash/test_1251091-1.html | DMD-DUMP-deprecated /home/kats/tmp/dmd/dmd-0-deprecated.txt
JavaScript error: http://mochi.test:8888/tests/SimpleTest/MemoryStats.js, line 112: ReferenceError: DMDReportAndDump is not defined

I think this is because the typeof check at http://searchfox.org/mozilla-central/rev/12cf11303392edac9f1da0c02e3d9ad2ecc8f4d3/testing/mochitest/tests/SimpleTest/MemoryStats.js#107 is passing because "undefined" (the string, returned by typeof) is not equal to |undefined| (the JS primitive, on the RHS of the condition).

I'll have a patch up once I verify the fix.
This fixes the error in comment 0 but it doesn't seem to actually get DMD working. I'm still investigating, but this patch should probably land regardless.
Comment on attachment 8839743 [details]
Bug 1341450 - Repair incorrect check for missing DMDReportAndDump function.

https://reviewboard.mozilla.org/r/114314/#review115770

good find!
Attachment #8839743 - Flags: review?(jmaher) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0894bd95e396
Repair incorrect check for missing DMDReportAndDump function. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/0894bd95e396
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.