Closed Bug 1341490 Opened 4 years ago Closed 4 years ago

Remove bitrotting disabled gfx gtests

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(2 files)

https://searchfox.org/mozilla-central/source/gfx/tests/gtest/moz.build

These tests are not running in CI, aren't tracked by a re-enabler bug, and nowadays produce a pageful of build errors when re-enabled. This is basically `#if 0` code, which we prefer not to have.

(My initial goal here was to rename the gigantic per-text-runs.h to something like per-text-runs.inc, so that my editor won't spend ages parsing it. But I found a ton of dead code nearby, so now I'd rather just remove it all.)
Attached patch font testsSplinter Review
Assignee: nobody → dmajor
Attachment #8839756 - Flags: review?(jfkthame)
Attached patch layer testSplinter Review
Attachment #8839757 - Flags: review?(nical.bugzilla)
Comment on attachment 8839756 [details] [diff] [review]
font tests

Review of attachment 8839756 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. It's dead, time it was buried.

You can also nuke gfxFontSelectionTests.h while you're here.
Attachment #8839756 - Flags: review?(jfkthame) → review+
Attachment #8839757 - Flags: review?(nical.bugzilla) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/651dbded7f74
Remove bitrotting disabled fonts gtests. r=jfkthame
https://hg.mozilla.org/integration/mozilla-inbound/rev/665bcbc87862
Remove bitrotting disabled layer gtest. r=nical
Backed out for bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8dc302b26ac7620191c8d53e52b0bb5b44886dd
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa7b9c7d739737d7015e46c47810c499ebc0e0e

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=665bcbc8786275c50fb9b6b473a8f798e6f72e10&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=79477229&repo=mozilla-inbound

[task 2017-02-22T23:27:43.736595Z] 23:27:43     INFO -  /home/worker/workspace/build/src/sccache2/sccache /home/worker/workspace/build/src/gcc/bin/gcc -std=gnu99 -o mp_comba.o -c  -DNDEBUG -DTRIMMED=1 '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DNSS_USE_64 -DNSS_X86_OR_X64 -DNSS_X64 -DHAVE_INT128_SUPPORT -DFREEBL_LOWHASH -DFREEBL_NO_DEPEND -DMP_IS_LITTLE_ENDIAN -DNSS_BEVAND_ARCFOUR -DMPI_AMD64 -DMP_ASSEMBLY_MULTIPLY -DNSS_USE_COMBA -DUSE_HW_AES -DINTEL_GCM -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_LIBPKIX -I/home/worker/workspace/build/src/security/nss/lib/freebl -I/home/worker/workspace/build/src/obj-firefox/security/nss/lib/freebl/freebl_freeblpriv3 -I/home/worker/workspace/build/src/security/nss/lib/freebl/mpi -I/home/worker/workspace/build/src/security/nss/lib/freebl/ecl -I/home/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/home/worker/workspace/build/src/obj-firefox/dist/include/private/nss -I/home/worker/workspace/build/src/obj-firefox/dist/include/nss -I/home/worker/workspace/build/src/obj-firefox/dist/include    -fPIC  -include /home/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/mp_comba.o.pp  -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe  -g -freorder-blocks -Os -fno-omit-frame-pointer    /home/worker/workspace/build/src/security/nss/lib/freebl/mpi/mp_comba.c
[task 2017-02-22T23:27:43.812537Z] 23:27:43     INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:137:0:
[task 2017-02-22T23:27:43.813372Z] 23:27:43     INFO -  /home/worker/workspace/build/src/gfx/thebes/gfxHarfBuzzShaper.cpp: In member function 'hb_position_t gfxHarfBuzzShaper::GetGlyphHAdvance(hb_codepoint_t) const':
[task 2017-02-22T23:27:43.813475Z] 23:27:43     INFO -  /home/worker/workspace/build/src/gfx/thebes/gfxHarfBuzzShaper.cpp:339:11: error: reference to 'GlyphMetrics' is ambiguous
[task 2017-02-22T23:27:43.813549Z] 23:27:43     INFO -       const GlyphMetrics* metrics =
[task 2017-02-22T23:27:43.813807Z] 23:27:43     INFO -             ^
[task 2017-02-22T23:27:43.814110Z] 23:27:43     INFO -  /home/worker/workspace/build/src/gfx/thebes/gfxHarfBuzzShaper.cpp:317:8: note: candidates are: struct GlyphMetrics
[task 2017-02-22T23:27:43.814321Z] 23:27:43     INFO -   struct GlyphMetrics {
[task 2017-02-22T23:27:43.814569Z] 23:27:43     INFO -          ^
[task 2017-02-22T23:27:43.815491Z] 23:27:43     INFO -  In file included from /home/worker/workspace/build/src/gfx/thebes/gfxBaseSharedMemorySurface.h:10:0,
[task 2017-02-22T23:27:43.815572Z] 23:27:43     INFO -                   from /home/worker/workspace/build/src/gfx/thebes/gfxBaseSharedMemorySurface.cpp:7,
[task 2017-02-22T23:27:43.815649Z] 23:27:43     INFO -                   from /home/worker/workspace/build/src/obj-firefox/gfx/thebes/Unified_cpp_gfx_thebes0.cpp:38:
[task 2017-02-22T23:27:43.815736Z] 23:27:43     INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/gfx/2D.h:679:8: note:                 struct mozilla::gfx::GlyphMetrics
[task 2017-02-22T23:27:43.815781Z] 23:27:43     INFO -   struct GlyphMetrics
[task 2017-02-22T23:27:43.815864Z] 23:27:43     INFO -          ^
...
Flags: needinfo?(dmajor)
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8465070e0b1f
Unified-build bustage fixes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e409ea0b2395
Remove bitrotting disabled fonts gtests. r=jfkthame
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8b504c39f6a
Remove bitrotting disabled layer gtest. r=nical
Flags: needinfo?(dmajor)
You need to log in before you can comment on or make changes to this bug.