Closed Bug 1341501 Opened 7 years ago Closed 7 years ago

Combine duplicate _query_latest_gecko_decision_task_id()

Categories

(Tree Management Graveyard :: Treeherder: SETA, defect, P3)

Product:
Tree Management Graveyard
Component:
Treeherder: SETA
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: rwood)

Details

Attachments

(1 file)

[treeherder] rwood-moz:bug1341501 > mozilla:master
47 bytes, text/x-github-pull-request
emorley
: review+
Details | Review 
https://github.com/mozilla/treeherder/blob/4086a7fb2f4b7c25e49bba51235fabb8e2bd452b/treeherder/seta/runnable_jobs.py#L41-L47

    def _query_latest_gecko_decision_task_id(self, repo_name):
        url = self.tc_index_url % repo_name
        logger.info('Fetching {}'.format(url))
        latest_task = fetch_json(url)
        task_id = latest_task['taskId']
        logger.info('For {} we found the task id: {}'.format(repo_name, task_id))
        return task_id

https://github.com/mozilla/treeherder/blob/4086a7fb2f4b7c25e49bba51235fabb8e2bd452b/treeherder/etl/runnable_jobs.py#L218-L224

    def _query_latest_gecko_decision_task_id(project):
        url = TASKCLUSTER_INDEX_URL % project
        logger.info('Fetching {}'.format(url))
        latest_task = fetch_json(url)
        task_id = latest_task['taskId']
        logger.info('For {} we found the task id: {}'.format(project, task_id))
        return task_id
Whiteboard: [good first bug]
I might as well clean this up.
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Whiteboard: [good first bug]
Attachment #8849275 - Flags: review?(emorley)
Comment on attachment 8849275 [details] [review]
[treeherder] rwood-moz:bug1341501 > mozilla:master

Thank you :-)
Attachment #8849275 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9fdf5d367e76a25f662bebfa7856b210006f2b87
Bug 1341501 - Combine duplicate _query_latest_gecko_decision_task_id functions (#2272)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: