Closed Bug 1341511 Opened 3 years ago Closed 3 years ago
[Static Analysis][Incorrect expressio] Ui
Compositor Controller Child .cpp: s Resize Cache .empty() is only useful for its return value, which is ignored
Do you mean .clear()?
This was found using the Coverity tool. https://developer.mozilla.org/en-US/docs/Debugging/Coverity
Assignee: nobody → rbarker
As we uplifted bug 1336929 into aurora, we will have to uplift this one too.
Attachment #8842155 - Flags: review?(dvander) → review+
Attachment #8842155 - Flags: review?(nchen) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b989e0a7b9 Replace std::map::empty() call with correct std::map::clear() call to remove all elements from the map r=dvander,jchen
Approval Request Comment [Feature/Bug causing the regression]: 1336929 [User impact if declined]: None [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No [Why is the change risky/not risky?]: The patch correctly clears a std::map after usage. [String changes made/needed]: none
Priority: -- → P2
Comment on attachment 8842566 [details] [diff] [review] 0001-Bug-1341511-Replace-std-map-empty-call-with-correct-std-map-clear-call-to-remove-all-elements-from-the-map-r-dvander-jchen-17030112-b60c2d4.patch Cleanup for regression fix, let's take this in 53.
Attachment #8842566 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.