Intermittent toolkit/components/url-classifier/tests/mochitest/test_reporturl.html | Test timed out.

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Treeherder Bug Filer, Assigned: tnguyen)

Tracking

({intermittent-failure})

unspecified
mozilla54
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox53 unaffected, firefox54 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(1 attachment, 3 obsolete attachments)

Comment 1

a year ago
25 failures in 173 pushes (0.145 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* mozilla-inbound: 13
* autoland: 9
* mozilla-central: 2
* graphics: 1

Platform breakdown:
* linux64: 10
* windows8-64: 8
* windows7-32: 4
* linux32: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-22&endday=2017-02-22&tree=all

Comment 2

a year ago
21 failures in 146 pushes (0.144 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* mozilla-inbound: 12
* autoland: 5
* graphics: 2
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 9
* windows8-64: 6
* windows7-32: 3
* linux32: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-23&endday=2017-02-23&tree=all

Comment 3

a year ago
29 failures in 182 pushes (0.159 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* mozilla-inbound: 13
* autoland: 9
* mozilla-central: 4
* try: 2
* graphics: 1

Platform breakdown:
* linux64: 8
* windows8-64: 6
* windows7-32: 6
* linux32: 6
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-24&endday=2017-02-24&tree=all
It looks like this test was just added in bug 1288633.

:tnguyen - Please try to make this test run more reliably. Consider disabling it while you work on it.
Blocks: 1288633
Flags: needinfo?(tnguyen)

Comment 5

a year ago
100 failures in 812 pushes (0.123 failures/push) were associated with this bug in the last 7 days. 

This is the #13 most frequent failure this week. 

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:
* mozilla-inbound: 48
* autoland: 33
* mozilla-central: 10
* try: 5
* graphics: 4

Platform breakdown:
* linux64: 33
* windows8-64: 24
* windows7-32: 20
* linux32: 14
* osx-10-10: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-20&endday=2017-02-26&tree=all
(Assignee)

Comment 8

a year ago
I still don't figure out why the intermittent failed.
Should disable the test first before I figure out why this failed.
Flags: needinfo?(tnguyen)
(Assignee)

Updated

a year ago
Whiteboard: [test disabled][leave open]
Comment hidden (offtopic)
(Assignee)

Updated

a year ago
Assignee: nobody → tnguyen
Status: NEW → ASSIGNED
(Assignee)

Comment 10

a year ago
Disable the test for now
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 11

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6332dc0a183
Disable test_reporturl.html due to intermittent failure. a=testonly
Keywords: checkin-needed
19 failures in 125 pushes (0.152 failures/push) were associated with this bug yesterday.  
Repository breakdown:
* autoland: 11
* mozilla-central: 4
* mozilla-inbound: 2
* graphics: 2

Platform breakdown:
* linux64: 7
* linux32: 4
* windows8-64: 3
* windows7-32: 3
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-27&endday=2017-02-27&tree=all
Whiteboard: [test disabled][leave open] → [test disabled][leave open][stockwell disabled]
(Assignee)

Updated

a year ago
Attachment #8841462 - Attachment is obsolete: true
(Assignee)

Comment 15

a year ago
Created attachment 8842366 [details] [diff] [review]
Using the valid update url provider in test

MozReview-Commit-ID: 46bzJ4DVh44
(Assignee)

Updated

a year ago
Attachment #8842366 - Flags: review?(gpascutto)
(Assignee)

Comment 16

a year ago
"fake" provider appears to be failed to update because the update url does not exist
https://searchfox.org/mozilla-central/rev/9c1c7106eef137e3413fd867fc1ddfb1d3f6728c/addon-sdk/source/test/preferences/firefox.json#12

We may use "mozilla" in this case, this is good enough to test non-google provider.
(Assignee)

Comment 17

a year ago
Created attachment 8842409 [details] [diff] [review]
Using the valid update url provider in test

MozReview-Commit-ID: BxIW4cMD4V0
(Assignee)

Updated

a year ago
Attachment #8842366 - Attachment is obsolete: true
Attachment #8842366 - Flags: review?(gpascutto)
(Assignee)

Updated

a year ago
Attachment #8842409 - Flags: review?(gpascutto)
(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #16)
> "fake" provider appears to be failed to update because the update url does
> not exist


Can you explain why this causes the test to fail?
happy to see a fix in here :)
(Assignee)

Comment 20

a year ago
As we added a test data to "fake-phish-simple" list, we enabled "fake" provider actively, then in the next update we will try to connect to server and update the fake-phish-simple
The update url of "fake" provider currently is empty (set to about:blank as default, others default is set) and apprenrently will be failed. 
The about:blank is malformed download url, so the update task will bailed out before the channel is opened (asyncopen) https://searchfox.org/mozilla-central/rev/9c1c7106eef137e3413fd867fc1ddfb1d3f6728c/toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp#162
OnStopRequest will not be fired and somehow the next update task will be blocked (timed out).
This is what I traced and this occurs in all failures
(Assignee)

Comment 21

a year ago
OnStopRequest will cancel/finish update then change the inUpdate status of dbservice so the next update could run
https://searchfox.org/mozilla-central/rev/9c1c7106eef137e3413fd867fc1ddfb1d3f6728c/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1919
That explains why the update tests fail. But why is that affecting this test? Is it failing to get its own DB entries inserted that it's using to trigger a warning screen?
If that causes problems, doesn't this mean our own test tables would be affected too?
(Assignee)

Comment 24

a year ago
I think it would be ok if we run update from listmanager (trigger another update request of another list), but has been effected if we run mochitest which calls update directly from dbservice such as
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm#90
or https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/browser/classifierHelper.js#193
These call will be blocked because dbservice is still in "inupdate" and it may lead to not be able to "setup" data for next certain test.
That's why after running the test test_reporturl.html, we may have randomly timeout of succession test (like bug 1203438 or bug 1209786).
Comment on attachment 8842409 [details] [diff] [review]
Using the valid update url provider in test

Review of attachment 8842409 [details] [diff] [review]:
-----------------------------------------------------------------

Add a small comment explaining the provider needs a valid update URL or the updates inserting the test data will fail.
Attachment #8842409 - Flags: review?(gpascutto) → review+
(Assignee)

Comment 26

a year ago
Created attachment 8842457 [details] [diff] [review]
Using the valid update url provider in test

MozReview-Commit-ID: 50NcRd2e9hB
(Assignee)

Updated

a year ago
Attachment #8842409 - Attachment is obsolete: true
(Assignee)

Comment 27

a year ago
Comment on attachment 8842457 [details] [diff] [review]
Using the valid update url provider in test

Thanks gcp for your review
Attachment #8842457 - Flags: review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed
Whiteboard: [test disabled][leave open][stockwell disabled]

Comment 29

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30dc81445a1b
Using the valid update url provider in test. r=gcp
Keywords: checkin-needed

Comment 30

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/30dc81445a1b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [stockwell fixed]
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
21 failures in 783 pushes (0.027 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 11
* mozilla-central: 5
* mozilla-inbound: 2
* graphics: 2
* try: 1

Platform breakdown:
* linux64: 8
* linux32: 5
* windows8-64: 3
* windows7-32: 3
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-02-27&endday=2017-03-05&tree=all
1 failures in 892 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-beta: 1

Platform breakdown:
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1341514&startday=2017-06-19&endday=2017-06-25&tree=all
You need to log in before you can comment on or make changes to this bug.