Closed Bug 1341543 Opened 3 years ago Closed 3 years ago

Update libyuv to 054ec37f8e31e6131c8f19eb74395d29009d6604

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(7 files)

+++ This bug was initially created as a clone of Bug #1284803 +++

libyuv has not been updated since Bug 1284803, rev 1602

New functions and include files (planar_functions.h) are needed by consumers of libyuv, such as webrtc.  Also there are many improvements, especially in performance.

libyuv has moved to git: 
https://chromium.googlesource.com/libyuv/libyuv/
git clone https://chromium.googlesource.com/libyuv/libyuv
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e03f08a8a2c1690c757569bdfe83158789f1b40

I'll upload the patches once I verify they build on all platforms and I clean up the summaries (and split the last patch)
MozReview-Commit-ID: 35D3W0Dqrc8
Attachment #8839981 - Flags: review?(sotaro.ikeda.g)
MozReview-Commit-ID: H0o6ufAlnGx
Attachment #8839982 - Flags: review?(sotaro.ikeda.g)
Attached patch update_gyp.patchSplinter Review
So it can be easily reviewed independently of the update script's .patch files (several more to follow)
Attachment #8839984 - Flags: review?(sotaro.ikeda.g)
Attachment #8839985 - Flags: review?(sotaro.ikeda.g)
Attachment #8839986 - Flags: review?(sotaro.ikeda.g)
Attachment #8839987 - Flags: review?(sotaro.ikeda.g)
Attachment #8839988 - Flags: review?(sotaro.ikeda.g)
sotaro: note, I'll email you the import patch generated by the update script (running it the first time requires a little setup; future runs should be trivial to do via update.py --commit XXXXXXXX).

Patch order is: 
 0 A libyuv_remove_and_update_to_054ec37f8e31e6131c8f19eb74395d29009d6604
 1 A initial_update_framework
 2 A update_for_libyuv_move
 3 A SIMD_ALIGNED
 4 A dont_use_matrix_gfx

I have a green Try -b do -p all -u all
Attachment #8839981 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839982 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839984 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839985 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839986 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839987 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839988 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/654b04ab210a
Import libyuv rev 054ec37f8e31e6131c8f19eb74395d29009d6604 from upstream rs=jesup,sotaro
https://hg.mozilla.org/integration/mozilla-inbound/rev/558258e4712a
Update SIMD_ALIGNED in gfx to match libyuv's definition r=sotaro
https://hg.mozilla.org/integration/mozilla-inbound/rev/b21f4e412b66
don't use internal-only I4xxToARGBMatrix() functions from libyuv r=sotaro
Depends on: 1342730
Depends on: 1342732
I'm sure we'll be fine, but as a rule, I'd prefer to have more than a weekend on nightly when we update third party libraries.  Preferably in the first half of the nightly cycle.
Summary: Update libyuv → Update libyuv to 054ec37f8e31e6131c8f19eb74395d29009d6604
You need to log in before you can comment on or make changes to this bug.