Closed
Bug 1341543
Opened 7 years ago
Closed 7 years ago
Update libyuv to 054ec37f8e31e6131c8f19eb74395d29009d6604
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(7 files)
1.72 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
5.62 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
2.60 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
3.04 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
1.95 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
3.36 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
2.64 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1284803 +++ libyuv has not been updated since Bug 1284803, rev 1602 New functions and include files (planar_functions.h) are needed by consumers of libyuv, such as webrtc. Also there are many improvements, especially in performance. libyuv has moved to git: https://chromium.googlesource.com/libyuv/libyuv/ git clone https://chromium.googlesource.com/libyuv/libyuv
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e03f08a8a2c1690c757569bdfe83158789f1b40 I'll upload the patches once I verify they build on all platforms and I clean up the summaries (and split the last patch)
Assignee | ||
Updated•7 years ago
|
Blocks: libyuv-updates
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: 35D3W0Dqrc8
Attachment #8839981 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: H0o6ufAlnGx
Attachment #8839982 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 4•7 years ago
|
||
So it can be easily reviewed independently of the update script's .patch files (several more to follow)
Attachment #8839984 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8839985 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8839986 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8839987 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8839988 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 9•7 years ago
|
||
sotaro: note, I'll email you the import patch generated by the update script (running it the first time requires a little setup; future runs should be trivial to do via update.py --commit XXXXXXXX). Patch order is: 0 A libyuv_remove_and_update_to_054ec37f8e31e6131c8f19eb74395d29009d6604 1 A initial_update_framework 2 A update_for_libyuv_move 3 A SIMD_ALIGNED 4 A dont_use_matrix_gfx I have a green Try -b do -p all -u all
Updated•7 years ago
|
Attachment #8839981 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•7 years ago
|
Attachment #8839982 -
Flags: review?(sotaro.ikeda.g) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Another green Try with the final patchset: https://treeherder.mozilla.org/#/jobs?repo=try&revision=725250a1bdfd4f4b3f1b2828ae8bdc653c22910c
Updated•7 years ago
|
Attachment #8839984 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•7 years ago
|
Attachment #8839985 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•7 years ago
|
Attachment #8839986 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•7 years ago
|
Attachment #8839987 -
Flags: review?(sotaro.ikeda.g) → review+
Updated•7 years ago
|
Attachment #8839988 -
Flags: review?(sotaro.ikeda.g) → review+
Comment 11•7 years ago
|
||
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/654b04ab210a Import libyuv rev 054ec37f8e31e6131c8f19eb74395d29009d6604 from upstream rs=jesup,sotaro https://hg.mozilla.org/integration/mozilla-inbound/rev/558258e4712a Update SIMD_ALIGNED in gfx to match libyuv's definition r=sotaro https://hg.mozilla.org/integration/mozilla-inbound/rev/b21f4e412b66 don't use internal-only I4xxToARGBMatrix() functions from libyuv r=sotaro
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/654b04ab210a https://hg.mozilla.org/mozilla-central/rev/558258e4712a https://hg.mozilla.org/mozilla-central/rev/b21f4e412b66
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
I'm sure we'll be fine, but as a rule, I'd prefer to have more than a weekend on nightly when we update third party libraries. Preferably in the first half of the nightly cycle.
Summary: Update libyuv → Update libyuv to 054ec37f8e31e6131c8f19eb74395d29009d6604
You need to log in
before you can comment on or make changes to this bug.
Description
•