Closed Bug 1341565 Opened 3 years ago Closed 3 years ago

Use external image for mask layer

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55

People

(Reporter: ethlin, Assigned: ethlin)

Details

Attachments

(1 file, 1 obsolete file)

Currently we get surface from mask layer and then call add_image. We should use external image to handle it.
Currently we only take image layer as mask layer. So I only implement the RenderMaskLayer in WebRenderImageLayer, and add MOZ_ASSERT for other cases.
Attachment #8840783 - Flags: review?(jmuizelaar)
Comment on attachment 8840783 [details] [diff] [review]
use external image for mask image

Review of attachment 8840783 [details] [diff] [review]:
-----------------------------------------------------------------

This will need to be reworked now that bug 1344396 has landed.
Attachment #8840783 - Flags: review?(jmuizelaar) → review-
I rebased the patch with the latest code.
Attachment #8840783 - Attachment is obsolete: true
Attachment #8844878 - Flags: review?(jmuizelaar)
Comment on attachment 8844878 [details] [diff] [review]
use external image for mask image

Review of attachment 8844878 [details] [diff] [review]:
-----------------------------------------------------------------

In the future I think we should be able to avoid having any mask layers but this is fine for now.
Attachment #8844878 - Flags: review?(jmuizelaar) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/900d50697c14
Use external image to handle mask layer. r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.