1341565 - Use external image for mask layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ethan Lin[:ethlin]]

Currently we get surface from mask layer and then call add_image. We should use external image to handle it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: use external image for mask image

Currently we only take image layer as mask layer. So I only implement the RenderMaskLayer in WebRenderImageLayer, and add MOZ_ASSERT for other cases.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8840783 [details] [diff] [review]
use external image for mask image

Review of attachment 8840783 [details] [diff] [review]:
-----------------------------------------------------------------

This will need to be reworked now that bug 1344396 has landed.

Comment 3

[Ethan Lin[:ethlin]]

Attachment: use external image for mask image

I rebased the patch with the latest code.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8844878 [details] [diff] [review]
use external image for mask image

Review of attachment 8844878 [details] [diff] [review]:
-----------------------------------------------------------------

In the future I think we should be able to avoid having any mask layers but this is fine for now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/900d50697c14
Use external image to handle mask layer. r=jrmuizel

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/900d50697c14