1341587 - use of ECL_USE_FP in nss/lib/freebl should be avoided after recent nss version update

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170123014550

Steps to reproduce:

While building FF52b08 on sparc Solaris it fails as it's missing ecp_fp.h. But this file was removed with recent nss version update. security/nss/lib/freebl/Makefile should be modified to avoid use ECL_USE_FP.

Comment 1

[Petr Sumbera]

Attachment: Bug1341587.patch

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

I think you want a NSS and/or Build Config peer to review this.
(i.e. neither me, nor jfkthame)

For a list of possible names, please see:
https://wiki.mozilla.org/Modules/All#security
https://wiki.mozilla.org/Modules/All#Build_Config

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Looks like we'd probably want to keep -DECL_USE_FP?

Comment 4

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Review of attachment 8839891 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, looks like we missed something here. There is no FP code anymore so this should go away as well. Thanks for the patch

Comment 5

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/f56187802acea018c359b5943350a298f6cca417

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Guess this is already in :)