bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

use of ECL_USE_FP in nss/lib/freebl should be avoided after recent nss version update

RESOLVED FIXED in 3.30

Status

NSS
Build
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Petr Sumbera, Assigned: Petr Sumbera)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170123014550

Steps to reproduce:

While building FF52b08 on sparc Solaris it fails as it's missing ecp_fp.h. But this file was removed with recent nss version update. security/nss/lib/freebl/Makefile should be modified to avoid use ECL_USE_FP.

Updated

a year ago
Component: Untriaged → Build Config
OS: Unspecified → Other
Hardware: Unspecified → x86
(Assignee)

Comment 1

a year ago
Created attachment 8839891 [details] [diff] [review]
Bug1341587.patch
Attachment #8839891 - Flags: review?(mats)
Attachment #8839891 - Flags: review?(jfkthame)
Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

I think you want a NSS and/or Build Config peer to review this.
(i.e. neither me, nor jfkthame)

For a list of possible names, please see:
https://wiki.mozilla.org/Modules/All#security
https://wiki.mozilla.org/Modules/All#Build_Config
Attachment #8839891 - Flags: review?(mats)
Attachment #8839891 - Flags: review?(jfkthame)
(Assignee)

Updated

a year ago
Attachment #8839891 - Flags: review?(ttaubert)
Attachment #8839891 - Flags: review?(mshal)
Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Looks like we'd probably want to keep -DECL_USE_FP?
Attachment #8839891 - Flags: review?(ttaubert) → review?(franziskuskiefer)
Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Review of attachment 8839891 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, looks like we missed something here. There is no FP code anymore so this should go away as well. Thanks for the patch
Attachment #8839891 - Flags: review?(franziskuskiefer) → review+
https://hg.mozilla.org/projects/nss/rev/f56187802acea018c359b5943350a298f6cca417
Assignee: nobody → nobody
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
Component: Build Config → Build
Product: Firefox → NSS
Resolution: --- → FIXED
Target Milestone: --- → 3.30
Version: 52 Branch → trunk
Assignee: nobody → petr.sumbera
Comment on attachment 8839891 [details] [diff] [review]
Bug1341587.patch

Guess this is already in :)
Attachment #8839891 - Flags: review?(mshal)
You need to log in before you can comment on or make changes to this bug.