Closed
Bug 1341704
Opened 7 years ago
Closed 7 years ago
don't assume there's only one version of each job type on each platform in backfilling
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla54
People
(Reporter: bstack, Assigned: bstack)
Details
Attachments
(1 file)
Due to my misunderstanding of how pushes look, I assumed there would only be one version of a job type on each platform in a push and wrote code to assert that would be true. https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/action.py#138-139 It turns out that I was wrong and we can have retriggers. This check is wrong and should be removed. In its place, we want to assert that if _all_ of the jobs matched by that filter set are green, we can stop backfilling, but otherwise, continue on.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8840008 -
Flags: review?(jmaher)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8840008 [details] Bug 1341704 - Fix assumption of uniqeness of treeherder jobs https://reviewboard.mozilla.org/r/114568/#review116008 nice simple fix. I think this is fine since we limit this to 5 historical pushes.
Attachment #8840008 -
Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f5fd56ce6ce Fix assumption of uniqeness of treeherder jobs r=jmaher
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9f5fd56ce6ce
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•