1341722 - Enable the extensions.webextensions.themes.enabled preference to ride the trains

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Once we get the dependencies for bug 1330335 fixed then we can enable the API on Nightly / DevEdition.

Comment 2

[Andy McKay]

Based on the meeting last week, we think this should be on by default and just ride to release and there was enough done to allow this. Is there anything in bug 1330335 that's a blocker?

Comment 3

[Matthew Wein [:mattw]]

Attachment: Bug 1341722 - Enable themes by default now that all of its blockers have landed

Review commit: https://reviewboard.mozilla.org/r/133184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133184/

Comment 4

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #2)
> Is there
> anything in bug 1330335 that's a blocker?

are we not doing bug 1344243?  :(

Comment 5

[Mike de Boer [:mikedeboer]]

(In reply to Andrew Swan [:aswan] from comment #4)
> are we not doing bug 1344243?  :(

(I added my comment to bug 1344243)

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8861218 [details]
Bug 1341722 - Enable themes by default now that all of its blockers have landed

https://reviewboard.mozilla.org/r/133184/#review136160

I'm not ready to remove the pref yet. Let's add it to firefox.js as `true` instead, so that Thunderbird and Seamonkey can still opt-out (by default).

Comment 7

[Andy McKay]

Is this still something we plan on doing for 55?

Comment 8

[Mike de Boer [:mikedeboer]]

I'll write the patch today - thanks for the ping!

Comment 9

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels.

Review commit: https://reviewboard.mozilla.org/r/144496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144496/

Comment 10

[Andy McKay]

Comment on attachment 8872956 [details]
Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels.

https://reviewboard.mozilla.org/r/144496/#review148538

::: browser/app/profile/firefox.js:201
(Diff revision 1)
>  pref("extensions.{972ce4c6-7e08-4474-a285-3208198ce6fd}.description", "chrome://browser/locale/browser.properties");
>  
>  pref("extensions.webextensions.themes.icons.buttons", "back,forward,reload,stop,bookmark_star,bookmark_menu,downloads,home,app_menu,cut,copy,paste,new_window,new_private_window,save_page,print,history,full_screen,find,options,addons,developer,synced_tabs,open_file,sidebars,share_page,subscribe,text_encoding,email_link,forget,pocket");
> +#ifndef RELEASE_OR_BETA
> +pref("extensions.webextensions.themes.enabled", true);
> +#endif

WHy not all channels and let it ride the trains?

Comment 11

[Mike de Boer [:mikedeboer]]

Comment on attachment 8872956 [details]
Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144496/diff/1-2/

Comment 12

[Richard Marti (:Paenglab)]

Shouldn't the extensions.webextensions.themes.icons.enabled be enabled too? Or is this planned for later?

Comment 13

[Mike de Boer [:mikedeboer]]

(In reply to Richard Marti (:Paenglab) from comment #12)
> Shouldn't the extensions.webextensions.themes.icons.enabled be enabled too?
> Or is this planned for later?

Later and it's not even certain whether we'll enable it at all... our UX dept is not at all convinced yet that the feature is a good idea. We'll see in the near future.

Comment 14

[Andy McKay]

Comment on attachment 8872956 [details]
Bug 1341722 - enable WebExtension themes by default on Nightly and Aurora channels.

https://reviewboard.mozilla.org/r/144496/#review148960

Might want to update bug title too.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b66b34bd7c
enable WebExtension themes by default on Nightly and Aurora channels. r=andym

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5b66b34bd7c