1341790 - Remove superfluous variables from confvars.sh

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Richard Marti (:Paenglab)]

confvars.sh has a lot of no more supported variables. We should remove them.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1341790.patch

I checked all removed variables in DXR and they appear only in confvars.sh files from C-C and in no other files there a check for the variable would be.

I also moved MOZ_MAINTENANCE_SERVICE=1 to all Windows builds and not only 32bit builds.

The MOZ_RUST_MP4PARSE=1 is to fix a bustage.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8840562 [details] [diff] [review]
Bug1341790.patch

Review of attachment 8840562 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! Thanks.

::: mail/confvars.sh
@@ +15,5 @@
>    MOZ_BUNDLED_FONTS=1
>  fi
>  
>  if test "$OS_ARCH" = "WINNT"; then
> +    MOZ_MAINTENANCE_SERVICE=1

Please indent to the if just below, that is, only two spaces.

@@ +42,3 @@
>  MOZ_PROFILE_MIGRATOR=1
>  MOZ_JSDOWNLOADS=1
> +MOZ_RUST_MP4PARSE=1

Introduced in bug 1219530, we never noticed. Strange.

Comment 3

[Jorg K (CEST = GMT+2)]

Oh, change the commit message:
Bug 1341790 - Remove superfluous variables from confvars.sh and add missing MOZ_RUST_MP4PARSE. r=jorgk

Comment 4

[Richard Marti (:Paenglab)]

Fixed indentation and commit message.

https://hg.mozilla.org/comm-central/rev/819fc5b85f129d9ab1c4ab222c68ce4aba65ae7a

Comment 5

[Frank-Rainer Grahl (:frg)]

I think  MOZ_BINARY_EXTENSIONS=1 is also ready for the scrapyard.

Comment 6

[Jorg K (CEST = GMT+2)]

MOZ_RUST_MP4PARSE removed again here:
https://hg.mozilla.org/comm-central/rev/84e007d226a212a9e79d93fb644aa6a7e57d60a7