Closed
Bug 1341790
Opened 5 years ago
Closed 5 years ago
Remove superfluous variables from confvars.sh
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 54.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
2.23 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
confvars.sh has a lot of no more supported variables. We should remove them.
Assignee | ||
Comment 1•5 years ago
|
||
I checked all removed variables in DXR and they appear only in confvars.sh files from C-C and in no other files there a check for the variable would be. I also moved MOZ_MAINTENANCE_SERVICE=1 to all Windows builds and not only 32bit builds. The MOZ_RUST_MP4PARSE=1 is to fix a bustage.
Comment 2•5 years ago
|
||
Comment on attachment 8840562 [details] [diff] [review] Bug1341790.patch Review of attachment 8840562 [details] [diff] [review]: ----------------------------------------------------------------- Excellent! Thanks. ::: mail/confvars.sh @@ +15,5 @@ > MOZ_BUNDLED_FONTS=1 > fi > > if test "$OS_ARCH" = "WINNT"; then > + MOZ_MAINTENANCE_SERVICE=1 Please indent to the if just below, that is, only two spaces. @@ +42,3 @@ > MOZ_PROFILE_MIGRATOR=1 > MOZ_JSDOWNLOADS=1 > +MOZ_RUST_MP4PARSE=1 Introduced in bug 1219530, we never noticed. Strange.
Attachment #8840562 -
Flags: review?(jorgk) → review+
Comment 3•5 years ago
|
||
Oh, change the commit message: Bug 1341790 - Remove superfluous variables from confvars.sh and add missing MOZ_RUST_MP4PARSE. r=jorgk
Assignee | ||
Comment 4•5 years ago
|
||
Fixed indentation and commit message. https://hg.mozilla.org/comm-central/rev/819fc5b85f129d9ab1c4ab222c68ce4aba65ae7a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
![]() |
||
Comment 5•5 years ago
|
||
I think MOZ_BINARY_EXTENSIONS=1 is also ready for the scrapyard.
Comment 6•5 years ago
|
||
MOZ_RUST_MP4PARSE removed again here: https://hg.mozilla.org/comm-central/rev/84e007d226a212a9e79d93fb644aa6a7e57d60a7
You need to log in
before you can comment on or make changes to this bug.
Description
•