Closed Bug 1341809 Opened 3 years ago Closed 3 years ago

Fix unified build bustage in GroupedHistory.{h,cpp}

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

I tried to add a file to dom/base, but it caused some bad build problems due to missing includes.
With this patch, I was able to move GroupedHistory.cpp from UNIFIED_SOURCES to SOURCES and it still builsd.
I checked that all of the types mentioned in the header have their headers included, but I did not do the same for the .cpp file.
Comment on attachment 8840119 [details]
Bug 1341809 - Fix unified build bustage in GroupedHistory.{h,cpp}.

https://reviewboard.mozilla.org/r/114646/#review116234
Attachment #8840119 - Flags: review?(ehsan) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34202e154011
Fix unified build bustage in GroupedHistory.{h,cpp}. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/34202e154011
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.