Closed Bug 1341915 Opened 3 years ago Closed 3 years ago

Create the Win32 nsAppShell hidden event window as a message-only window

Categories

(Core :: Widget: Win32, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

I hit a hang in inspect.exe (the platform SDK tool for enumerating a11y objects) and it turns out that inspect was blocked on a SendMessage to nsAppShell:EventWindow.

Upon looking at this code, it is clear to me that we should create this window as a message-only window (since that's what it is) - i.e. during creation we set its parent to be HWND_MESSAGE
(see https://msdn.microsoft.com/en-us/library/windows/desktop/ms632599(v=vs.85).aspx#message_only)

Otherwise it is visible to a bunch of tools that think it is a normal window, when in fact it is not.
Comment on attachment 8840185 [details]
Bug 1341915: Make win32 nsAppShell's event window message-only;

https://reviewboard.mozilla.org/r/114676/#review116360
Attachment #8840185 - Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b7d8840e54f
Make win32 nsAppShell's event window message-only; r=jimm
https://hg.mozilla.org/mozilla-central/rev/9b7d8840e54f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Depends on: 1395876
You need to log in before you can comment on or make changes to this bug.