Closed Bug 1341927 Opened 3 years ago Closed 3 years ago

Stylo reftest setup is broken because of canvas caching

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

The reftest harness caches canvases by URL, if they have no prefs specified.  Because the stylo changes to the harness add prefs via an out-of-band mechanism, they do NOT disable the caching.  As a result, if you have a reftest-stylo.list like this:

  == foo.html foo.html
  == foo.html foo.html

(which we have all over), then the first time we will load both things and render them with the prefs set and whatnot.  But the second time we will just hit the canvas cache (which has the Gecko rendering at that point) for both the test and the reference.  This will cause very confusing reftest failures!

We also have _tons_ of repeated lines like that in reftest-stylo.list files.

Fix coming up to make the stylo pref use the normal pref mechanism, which fixes this.
Comment on attachment 8840202 [details]
Bug 1341927.  Fix the stylo reftest setup to set prefs via the normal mechanism and hence not run afoul of the reftest harness canvas caching.

https://reviewboard.mozilla.org/r/114702/#review116204
Attachment #8840202 - Flags: review?(cam) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4939b26390dd
Fix the stylo reftest setup to set prefs via the normal mechanism and hence not run afoul of the reftest harness canvas caching.  r=heycam
Blocks: 1341988
https://hg.mozilla.org/mozilla-central/rev/4939b26390dd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.