Closed
Bug 1341959
Opened 7 years ago
Closed 7 years ago
Add blocklist entry for webgl2
Categories
(Core :: Graphics: CanvasWebGL, defect, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jgilbert, Assigned: milan)
Details
(Whiteboard: gfx-noted)
Attachments
(2 files)
We don't have an entry specifically for webgl2 right now, but we should add one.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(milan)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #2) > Created attachment 8841012 [details] > Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it. > > Review commit: https://reviewboard.mozilla.org/r/115364/diff/#index_header > See other reviews: https://reviewboard.mozilla.org/r/115364/ Feels like there is a piece missing for when the caller wants to check if WebGL2 is available or not - or is the only way to do that to try to create it and deal with the failure?
Flags: needinfo?(milan)
Reporter | ||
Comment 4•7 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #3) > (In reply to Milan Sreckovic [:milan] from comment #2) > > Created attachment 8841012 [details] > > Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it. > > > > Review commit: https://reviewboard.mozilla.org/r/115364/diff/#index_header > > See other reviews: https://reviewboard.mozilla.org/r/115364/ > > Feels like there is a piece missing for when the caller wants to check if > WebGL2 is available or not - or is the only way to do that to try to create > it and deal with the failure? That's correct.
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8841012 [details] Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it. https://reviewboard.mozilla.org/r/115364/#review116926
Attachment #8841012 -
Flags: review?(jgilbert) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8841011 [details] Bug 1341959: Part 1. Allow WebGL2 to be blocked separately from WebGL overall. https://reviewboard.mozilla.org/r/115362/#review117148
Attachment #8841011 -
Flags: review?(mchang) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → milan
Pushed by msreckovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4187cda95a1d Part 1. Allow WebGL2 to be blocked separately from WebGL overall. r=mchang https://hg.mozilla.org/integration/autoland/rev/87bf65872b56 Part 2. Check if WebGL2 is blocked before creating it. r=jgilbert
Comment 8•7 years ago
|
||
Sorry had to back this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=81022756&repo=autoland&lineNumber=8390 https://hg.mozilla.org/integration/autoland/rev/f24d5588057b https://hg.mozilla.org/integration/autoland/rev/f76695801b2a
Flags: needinfo?(milan)
Assignee | ||
Comment 9•7 years ago
|
||
Thanks. I ran this test locally on Windows, but I keep forgetting that the tests really only properly run on OS X.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #11) > Comment on attachment 8841012 [details] > Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it. > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/115364/diff/1-2/ Update to the tests so that they pass on non-Windows platforms (this entry is only relevant on Windows, but that's how the tests run.) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c8b5b8f7a6a887447eae02cbc5e91249f5559e3
Flags: needinfo?(milan)
Comment 13•7 years ago
|
||
Pushed by msreckovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de25c9ee667a Part 1. Allow WebGL2 to be blocked separately from WebGL overall. r=mchang https://hg.mozilla.org/integration/autoland/rev/eb7ca2f437e7 Part 2. Check if WebGL2 is blocked before creating it. r=jgilbert
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de25c9ee667a https://hg.mozilla.org/mozilla-central/rev/eb7ca2f437e7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•