Closed Bug 1341959 Opened 3 years ago Closed 3 years ago

Add blocklist entry for webgl2

Categories

(Core :: Canvas: WebGL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jgilbert, Assigned: milan)

Details

(Whiteboard: gfx-noted)

Attachments

(2 files)

We don't have an entry specifically for webgl2 right now, but we should add one.
Flags: needinfo?(milan)
(In reply to Milan Sreckovic [:milan] from comment #2)
> Created attachment 8841012 [details]
> Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it.
> 
> Review commit: https://reviewboard.mozilla.org/r/115364/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/115364/

Feels like there is a piece missing for when the caller wants to check if WebGL2 is available or not - or is the only way to do that to try to create it and deal with the failure?
Flags: needinfo?(milan)
(In reply to Milan Sreckovic [:milan] from comment #3)
> (In reply to Milan Sreckovic [:milan] from comment #2)
> > Created attachment 8841012 [details]
> > Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it.
> > 
> > Review commit: https://reviewboard.mozilla.org/r/115364/diff/#index_header
> > See other reviews: https://reviewboard.mozilla.org/r/115364/
> 
> Feels like there is a piece missing for when the caller wants to check if
> WebGL2 is available or not - or is the only way to do that to try to create
> it and deal with the failure?

That's correct.
Comment on attachment 8841012 [details]
Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it.

https://reviewboard.mozilla.org/r/115364/#review116926
Attachment #8841012 - Flags: review?(jgilbert) → review+
Comment on attachment 8841011 [details]
Bug 1341959: Part 1. Allow WebGL2 to be blocked separately from WebGL overall.

https://reviewboard.mozilla.org/r/115362/#review117148
Attachment #8841011 - Flags: review?(mchang) → review+
Assignee: nobody → milan
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4187cda95a1d
Part 1. Allow WebGL2 to be blocked separately from WebGL overall. r=mchang
https://hg.mozilla.org/integration/autoland/rev/87bf65872b56
Part 2. Check if WebGL2 is blocked before creating it. r=jgilbert
Thanks.  I ran this test locally on Windows, but I keep forgetting that the tests really only properly run on OS X.
(In reply to Milan Sreckovic [:milan] from comment #11)
> Comment on attachment 8841012 [details]
> Bug 1341959: Part 2. Check if WebGL2 is blocked before creating it.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/115364/diff/1-2/

Update to the tests so that they pass on non-Windows platforms (this entry is only relevant on Windows, but that's how the tests run.)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c8b5b8f7a6a887447eae02cbc5e91249f5559e3
Flags: needinfo?(milan)
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de25c9ee667a
Part 1. Allow WebGL2 to be blocked separately from WebGL overall. r=mchang
https://hg.mozilla.org/integration/autoland/rev/eb7ca2f437e7
Part 2. Check if WebGL2 is blocked before creating it. r=jgilbert
https://hg.mozilla.org/mozilla-central/rev/de25c9ee667a
https://hg.mozilla.org/mozilla-central/rev/eb7ca2f437e7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.