Closed
Bug 1341975
Opened 7 years ago
Closed 7 years ago
Regression: empty list UI is broken
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox54 verified)
Tracking | Status | |
---|---|---|
firefox54 | --- | verified |
People
(Reporter: gasolin, Assigned: gasolin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor-reserve])
Attachments
(1 file)
from bug 1316291: empty list UI is broken since there was an additional "s" added by mistake
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8840297 [details] Bug 1341975 - fix Regression: empty list UI is broken; https://reviewboard.mozilla.org/r/114794/#review116262 I think there are lots of places used requests, so I'd prefer to use requests-list-empty-notice instead.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8840297 [details] Bug 1341975 - fix Regression: empty list UI is broken; https://reviewboard.mozilla.org/r/114794/#review116296
Attachment #8840297 -
Flags: review?(rchien) → review-
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8840297 [details] Bug 1341975 - fix Regression: empty list UI is broken; The component contains `.request-list-empty-notice` is `request-list-empty`, so it make sense to prefix it with `.request-list-` We should focus on fix regression and then decide if we want to rename all components in next bug
Attachment #8840297 -
Flags: review- → review?(rchien)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8840297 [details] Bug 1341975 - fix Regression: empty list UI is broken; https://reviewboard.mozilla.org/r/114794/#review116302 LGTM.
Attachment #8840297 -
Flags: review?(rchien) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24ba72b5661d fix Regression: empty list UI is broken;r=rickychien
Keywords: checkin-needed
Updated•7 years ago
|
Iteration: --- → 54.3 - Mar 6
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor] → [netmonitor-reserve]
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24ba72b5661d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: ciprian.georgiu
Comment 10•7 years ago
|
||
This issue is verified fixed on latest Aurora 54.0a2 (2017-03-06) using Windows 10 x64 and Mac OS X 10.11.6. Marking here accordingly!
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•