Closed Bug 1341975 Opened 3 years ago Closed 3 years ago

Regression: empty list UI is broken

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(firefox54 verified)

VERIFIED FIXED
Firefox 54
Iteration:
54.3 - Mar 6
Tracking Status
firefox54 --- verified

People

(Reporter: gasolin, Assigned: gasolin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(1 file)

from bug 1316291: empty list UI is broken since there was an additional "s" added by mistake
Comment on attachment 8840297 [details]
Bug 1341975 - fix Regression: empty list UI is broken;

https://reviewboard.mozilla.org/r/114794/#review116262

I think there are lots of places used requests, so I'd prefer to use requests-list-empty-notice instead.
Comment on attachment 8840297 [details]
Bug 1341975 - fix Regression: empty list UI is broken;

https://reviewboard.mozilla.org/r/114794/#review116296
Attachment #8840297 - Flags: review?(rchien) → review-
Comment on attachment 8840297 [details]
Bug 1341975 - fix Regression: empty list UI is broken;

The component contains `.request-list-empty-notice` is `request-list-empty`, so it make sense to prefix it with `.request-list-` 

We should focus on fix regression and then decide if we want to rename all components in next bug
Attachment #8840297 - Flags: review- → review?(rchien)
Comment on attachment 8840297 [details]
Bug 1341975 - fix Regression: empty list UI is broken;

https://reviewboard.mozilla.org/r/114794/#review116302

LGTM.
Attachment #8840297 - Flags: review?(rchien) → review+
test green, thanks
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24ba72b5661d
fix Regression: empty list UI is broken;r=rickychien
Keywords: checkin-needed
Iteration: --- → 54.3 - Mar 6
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor] → [netmonitor-reserve]
https://hg.mozilla.org/mozilla-central/rev/24ba72b5661d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Flags: qe-verify? → qe-verify+
QA Contact: ciprian.georgiu
This issue is verified fixed on latest Aurora 54.0a2 (2017-03-06) using Windows 10 x64 and Mac OS X 10.11.6. Marking here accordingly!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.