1342052 - [Windows] A webextension can be installed after it is removed from search results list

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: gif1.gif

[Affected versions]:
Firefox 54.0a1 (2017-02-22)

[Affected platforms]:
Windows 10 64-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Navigate to Add-ons Manager -> Extensions and search for a webextension.
5.Click “Install” button.
6.Click “X” button from download progress bar.
7.Click “Add” button from permissions pop-up.


[Expected Results]:
a) Remove “X” button from download progress bar.
b) Removing the add-on should also discard the permissions pop-up.


[Actual Results]:
- The add-on is removed from search results list, but the permissions doorhanger remains displayed and the add-on is successfully installed after clicking “Add” button.
- See attached video.

[Additional notes]:
This issue is not reproducible on Ubuntu 16.04 32-bit and Mac Os X 10.12.1. Permissions doorhanger remains displayed after removing the add-on but the extension is not installed while clicking on "Add" button.

Comment 1

[Andrew Swan [:aswan]]

This is quirky but I don't think it's really a problem, by clicking "Add" the user indicates that they want to install this extension.  I'm reluctant to add a bunch more code to try to keep different UI pieces in sync for something like this.  Markus, any opinion?

Comment 2

[Markus Jaritz [:designakt] (UX)]

We could just get rid of that search page altogether like suggested in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1263313
But I do not know the progress on that.
Other than that this can only be solved if the dialog disappears if the install is canceled.
Otherwise they have to cancel twice, which is wrong. 
We know that a lot of installs happen through that site[1], so we should take care of the experience there.


[1]For Adblock Plus it is most important download source: https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/statistics/downloads/sources/?last=30

Comment 3

[Andrew Swan [:aswan]]

Replacing the search page is a substantial project.  I think it would start with building the AMO pages but there have been other higher priority projects over there.
In any case, I stand by my original assertion that this isn't a big problem so I propose we keep this bug open but at a low priority and not blocking permissions.

Comment 4

[Andrew Swan [:aswan]]

We're getting close to landing bug 1263313 which makes this irrelevant