The embedded TryChooser is out of date with upstream, embed the HTTPS version

RESOLVED FIXED

Status

MozReview
Review Board: User Interface
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: imadueme, Assigned: glob)

Tracking

Production

Details

(Reporter)

Description

8 months ago
Currently mozreview hosts a copy of the TryChooser page from releng. This was done because historically that page wasn't being served via HTTPS, thus the hosted copy to avoid mix content errors. 

It appears that the hosted one is now out of date with releng's upstream. For example, our hosted version currently doesn't have the "use artifact build" checkbox. It is uncertain when this changed.

Bug 1302631 added HTTPS hosting for the upstream trychooser page, so I think we can just use that now and not have to worry about being out of date.
(Assignee)

Comment 1

8 months ago
i'll fix this; should be quick.
Assignee: nobody → glob
(Assignee)

Comment 2

8 months ago
updated the try url for the gecko repo to https://www.mozilla-releng.net/trychooser/?embed

will remove our copy of trychooser once i hear that it's good.
(Reporter)

Comment 3

8 months ago
Looks good to me on production, thanks!
(Reporter)

Comment 4

8 months ago
Want to close this bug and create a new one for removing the old trychooser?
Flags: needinfo?(glob)
(Assignee)

Comment 5

8 months ago
no, tracking with this bug is fine.
Flags: needinfo?(glob)

Comment 6

8 months ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/b75273d500fe
mozreview: remove our trychooser copy
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.