1342125 - Turn on tls 1.3 early-data

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Dragana Damjanovic [:dragana]]

We should turn early-data now that there is h2 and h1 implementation.

Comment 1

[Dragana Damjanovic [:dragana]]

I meant turn on by default.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: bug_1342125.patch

Comment 3

[Dragana Damjanovic [:dragana]]

Any objections?

Comment 4

[Eric Rescorla (:ekr)]

We should do two things first:

1. Uplift MT's fix for PSK lifetime if that wasn't done.
2. Test it against Cloudflare now that it's landed.

Once we do those, yeah, bring it on

Comment 5

[Franziskus Kiefer [:franziskus]]

> 1. Uplift MT's fix for PSK lifetime if that wasn't done.

It's in central (see bug 1334127 comment 23).

Comment 6

[Patrick McManus [:mcmanus]]

dragana, do we need the psm part here? I think the gecko pref would turn it on even if the psm default was off, right? I think that's the best strategy - this should be opt in.

now that https://bugzilla.mozilla.org/show_bug.cgi?id=1343036 is fixed, I think we just need nss 3.31 to hit trunk and we can do this..

Comment 7

[Patrick McManus [:mcmanus]]

ekr says the nss uplift has happened. so a reviewable patch (perhaps without psm changes, if it still works..) and we can go.

could you also open a bug to enable non safe methods (with disabling pref) intended for 56?

Comment 8

[Dragana Damjanovic [:dragana]]

It should be working with gecko pref only. I will check.

Comment 9

[Dragana Damjanovic [:dragana]]

non-safe methods -> bug 1349242

Comment 10

[Dragana Damjanovic [:dragana]]

Attachment: bug_1342125_v2.patch

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7926abc3cd
Turn on 0RTT data. r=mcmanus

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c7926abc3cd