The default bug view has changed. See this FAQ.

enable webextension permissions prompts by default

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
a month ago
5 days ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

(Blocks: 1 bug)

51 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [permissions] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a month ago
This bug is to track all the blockers that need to be resolved before we can enable permissions prompts by default.  Once we're ready, we need to set "extensions.webextPermissionPrompts" to true in firefox.js
(Assignee)

Updated

a month ago
Blocks: 1308292
(Assignee)

Updated

a month ago
Depends on: 1329884
(Assignee)

Updated

a month ago
Depends on: 1332061
(Assignee)

Updated

a month ago
No longer depends on: 1340501
(Assignee)

Updated

a month ago
Depends on: 1340501
(Assignee)

Updated

a month ago
No longer depends on: 1340531
(Assignee)

Updated

a month ago
No longer depends on: 1340471
(Assignee)

Updated

29 days ago
Depends on: 1342896

Updated

28 days ago
Whiteboard: [permissions] triaged

Updated

26 days ago
No longer depends on: 1316460
(Assignee)

Updated

19 days ago
No longer depends on: 1329884
(Assignee)

Updated

17 days ago
Assignee: nobody → aswan
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 11

6 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=494e720872ac
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

6 days ago
Attachment #8849672 - Flags: review?(dtownsend)
Attachment #8846198 - Flags: review?(dtownsend)

Comment 14

6 days ago
mozreview-review
Comment on attachment 8849672 [details]
Bug 1342142 Part 1 Toolkit test cleanups

https://reviewboard.mozilla.org/r/122448/#review125072

::: toolkit/mozapps/extensions/test/browser/browser_searching.js:555
(Diff revision 5)
>      list.ensureElementIsVisible(remoteItem);
>  
>      installBtn = get_install_button(remoteItem);
>      is(installBtn.hidden, false, "Install button should be showing before install");
>      remoteItem.mAddon.install.addListener(listener);
> +    promiseNotification().then(() => {});

This looks like it doesn't do anything. What am I missing?

Comment 15

6 days ago
mozreview-review
Comment on attachment 8846198 [details]
Bug 1342142 Part 2 Enable webextension permission prompts

https://reviewboard.mozilla.org/r/119300/#review125078
Attachment #8846198 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 16

6 days ago
mozreview-review-reply
Comment on attachment 8849672 [details]
Bug 1342142 Part 1 Toolkit test cleanups

https://reviewboard.mozilla.org/r/122448/#review125072

> This looks like it doesn't do anything. What am I missing?

I probably could name things better, but `promiseNotification()` causes the notification to be accepted.  It also returns a Promise in case the caller cares to know when that has happened.  The `.then()` clause is pointless, I can remove it.

Comment 17

6 days ago
mozreview-review
Comment on attachment 8849672 [details]
Bug 1342142 Part 1 Toolkit test cleanups

https://reviewboard.mozilla.org/r/122448/#review125086

r+ with the then clause removed then.
Attachment #8849672 - Flags: review?(dtownsend) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 20

5 days ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa49f7a3e67d
Part 1 Toolkit test cleanups r=mossop
https://hg.mozilla.org/integration/autoland/rev/9f93b4b4a7ca
Part 2 Enable webextension permission prompts r=mossop

Comment 21

5 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fa49f7a3e67d
https://hg.mozilla.org/mozilla-central/rev/9f93b4b4a7ca
Status: NEW → RESOLVED
Last Resolved: 5 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.