Closed
Bug 1342155
Opened 9 years ago
Closed 9 years ago
disabled too many osx-debug tests, ones that are not run in e10s mode
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Infrastructure & Operations Graveyard
CIDuty
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: aselagea)
References
Details
Attachments
(2 files)
|
1.84 KB,
patch
|
jmaher
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
|
3.70 KB,
text/plain
|
Details |
we have xpcshell running, but we need to turn back on these non-e10s tests:
gtest
cppunit
jittest
mochitest-jetpack (needed until deprecated)
Updated•9 years ago
|
Component: General Automation → Buildduty
QA Contact: catlee → bugspam.Callek
| Assignee | ||
Comment 1•9 years ago
|
||
So we only want to remove the non-e10s tests that *do* have an e10s equivalent?
That would mean:
- the four tests listed in this bug's description
- mochitest-a11y, mochitest-chrome, xpcshell (which were explicitly kept enabled in bug 1339185)
- media-tests
- media-youtube-tests
Do we want to keep 'media-tests' and 'media-youtube-tests' as well? (since they don't have an e10s version)
Flags: needinfo?(jmaher)
| Reporter | ||
Comment 2•9 years ago
|
||
yes, we should keep those as well.
:RyanVM, can you ensure there is a bug on file and in the right hands for making the media*tests work in e10s mode?
Flags: needinfo?(jmaher) → needinfo?(ryanvm)
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → aselagea
| Assignee | ||
Comment 3•9 years ago
|
||
This should enable the missing tests back and make sure no non-e10s is dropped until the corresponding e10s version is present.
Attachment #8840825 -
Flags: review?(jmaher)
| Assignee | ||
Comment 4•9 years ago
|
||
Tests added.
| Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8840825 [details] [diff] [review]
bug_1342155.patch
Review of attachment 8840825 [details] [diff] [review]:
-----------------------------------------------------------------
this looks good, but we have so many edge cases, can you show me a builder diff?
Attachment #8840825 -
Flags: review?(jmaher) → review+
| Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #5)
> Comment on attachment 8840825 [details] [diff] [review]
> bug_1342155.patch
>
> Review of attachment 8840825 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> this looks good, but we have so many edge cases, can you show me a builder
> diff?
This doesn't affect the builders, since we do the changes on mozilla-tests/config.py. The difference in tests can be seen in 'diff.txt' (attached to this bug).
| Reporter | ||
Comment 7•9 years ago
|
||
that diff looks good! thanks
| Assignee | ||
Updated•9 years ago
|
Attachment #8840825 -
Flags: checked-in+
| Assignee | ||
Comment 8•9 years ago
|
||
Merged the change in production: https://hg.mozilla.org/build/buildbot-configs/rev/da14345b72d4
Comment 9•9 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #2)
> :RyanVM, can you ensure there is a bug on file and in the right hands for
> making the media*tests work in e10s mode?
I have no idea why you're asking me to do this. I don't even know who owns them. I suggest pinging Maire and going from there.
Flags: needinfo?(ryanvm)
| Assignee | ||
Comment 10•9 years ago
|
||
I think the work here is done, marking the bug as fixed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Release Engineering → Infrastructure & Operations
Updated•6 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•