Closed Bug 1342188 Opened 7 years ago Closed 7 years ago

stylo: various image-fit testcases hit scary fromLine->IsBlock() == fromLine->mFirstChild->IsBlockOutside() assertion failures

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bzbarsky, Unassigned)

References

Details

Attachments

(1 file)

Pretty typical:

REFTEST TEST-LOAD | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/images3/object-fit-scale-down-png-001o.html 
...
 ###!!! ASSERTION: Disagreement about whether it's a block or not: 'fromLine->IsBlock() == fromLine->mFirstChild->IsBlockOutside()', file /home/worker/workspace/build/src/layout/generic/nsBlockFrame.cpp, line 2877

A bunch of tests in layout/reftests/w3c-css/submitted/images3/ and layout/reftests/images are disabled due to this.

Presumably we change our display-outside style but don't reframe?

Emilio, Bobby said you are working on something that might help here?
Flags: needinfo?(emilio+bugs)
Yeah, indeed a build with the patches I'm about to post for bug 1322317 make this assert go away.
Flags: needinfo?(emilio+bugs)
Awesome!
See Also: → 1343030
Priority: -- → P3
Comment on attachment 8858676 [details]
Bug 1342188 - Enable image reftest.

https://reviewboard.mozilla.org/r/130660/#review134218
Attachment #8858676 - Flags: review?(slyu) → review+
Thank you Shing!
https://hg.mozilla.org/mozilla-central/rev/f3c0e8300aef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.