Closed
Bug 1342188
Opened 7 years ago
Closed 7 years ago
stylo: various image-fit testcases hit scary fromLine->IsBlock() == fromLine->mFirstChild->IsBlockOutside() assertion failures
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Unassigned)
References
Details
Attachments
(1 file)
Pretty typical: REFTEST TEST-LOAD | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/images3/object-fit-scale-down-png-001o.html ... ###!!! ASSERTION: Disagreement about whether it's a block or not: 'fromLine->IsBlock() == fromLine->mFirstChild->IsBlockOutside()', file /home/worker/workspace/build/src/layout/generic/nsBlockFrame.cpp, line 2877 A bunch of tests in layout/reftests/w3c-css/submitted/images3/ and layout/reftests/images are disabled due to this. Presumably we change our display-outside style but don't reframe? Emilio, Bobby said you are working on something that might help here?
Flags: needinfo?(emilio+bugs)
Comment 1•7 years ago
|
||
Yeah, indeed a build with the patches I'm about to post for bug 1322317 make this assert go away.
Flags: needinfo?(emilio+bugs)
Reporter | ||
Comment 2•7 years ago
|
||
Awesome!
Updated•7 years ago
|
Priority: -- → P3
Comment 3•7 years ago
|
||
Bug 1322317 has been fixed, now we can run disabled tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bfbff913d1b25fc2170a609d0c19f58db3599da
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8858676 [details] Bug 1342188 - Enable image reftest. https://reviewboard.mozilla.org/r/130660/#review134218
Attachment #8858676 -
Flags: review?(slyu) → review+
Comment 6•7 years ago
|
||
Thank you Shing!
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3c0e8300aef Enable image reftest. r=shinglyu
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f3c0e8300aef
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
status-firefox54:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•