1342202 - Move Win7 mochitest-a11y to AWS

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9ad04c815559a310a31acc808ff8ba1fc78ec33&group_state=expanded

Comment 1

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1342202.patch

Comment 2

[Sebastian Pacurar [:spacurar]]

Attachment: diff

Comment 3

[Kim Moir [:kmoir] ET]

So I notice that in the diff that there are three or two jobs removed, but six or four jobs added.  Is this expected?  Shouldn't the jobs just be replaced on a one for one basis?

< Windows 7 32-bit autoland opt test mochitest-a11y ScriptFactory
< Windows 7 32-bit autoland pgo test mochitest-a11y ScriptFactory
1233d1230
< Windows 7 32-bit autoland debug test mochitest-a11y ScriptFactory
1373a1371,1372
> Windows 7 VM 32-bit autoland opt test mochitest-a11y ScriptFactory
> Windows 7 VM 32-bit autoland pgo test mochitest-a11y ScriptFactory
1449a1449
> Windows 7 VM 32-bit autoland debug test mochitest-a11y ScriptFactory
1475a1476,1477
> Windows 7 VM-GFX 32-bit autoland opt test mochitest-a11y ScriptFactory
> Windows 7 VM-GFX 32-bit autoland pgo test mochitest-a11y ScriptFactory
1492a1495
> Windows 7 VM-GFX 32-bit autoland debug test mochitest-a11y ScriptFactory
3113d3115
< Windows 7 32-bit elm opt test mochitest-a11y ScriptFactory
3122d3123
< Windows 7 32-bit elm debug test mochitest-a11y ScriptFactory
3196a3198
> Windows 7 VM 32-bit elm opt test mochitest-a11y ScriptFactory
3272a3275
> Windows 7 VM 32-bit elm debug test mochitest-a11y ScriptFactory
3285a3289
> Windows 7 VM-GFX 32-bit elm opt test mochitest-a11y ScriptFactory
3302a3307
> Windows 7 VM-GFX 32-bit elm debug test mochitest-a11y ScriptFactory
3801,3802d3805

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I don't think we want the VM-GFX jobs.

Comment 5

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1342202_v2.patch

Comment 6

[Sebastian Pacurar [:spacurar]]

Attachment: diff_v2

Comment 7

[Kim Moir [:kmoir] ET]

Comment on attachment 8841991 [details] [diff] [review]
bug_1342202_v2.patch

lgtm! thanks!

Comment 8

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1342202_v3.patch

We noticed travis errors after landing the patch and it turned out there were duplicates try tests for mochtest-a11y. Updated the patch to ignore try and checked that test-masters.sh returned no errors.

Comment 9

[Sebastian Pacurar [:spacurar]]

Attachment: diff_v3

Comment 10

[Alin Selagea [:aselagea]]

Comment on attachment 8842370 [details] [diff] [review]
bug_1342202_v3.patch

lgtm

Comment 11

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1342202_v4.patch

Comment 12

[Sebastian Pacurar [:spacurar]]

Attachment: diff_v4

Comment 13

[Kim Moir [:kmoir] ET]

Comment on attachment 8842923 [details] [diff] [review]
bug_1342202_v4.patch

Instead of explicitly specifying the branch i.e. try, could you just check if mochitest-ally exists already in the list of test suites for the hardware platform, and delete it on the vm platform? For all the branches, not just try.

Comment 14

[Kim Moir [:kmoir] ET]

Sebastian, I don't know if you saw my comment on the bug earlier about refactoring, this is why I didn't review

Comment 15

[Sebastian Pacurar [:spacurar]]

I saw your comment and I'm currently working on it.

Comment 16

[Kim Moir [:kmoir] ET]

okay great :-) thank you very much

Comment 17

[Kim Moir [:kmoir] ET]

If it's taking too long to refactor don't worry about it and we can land it in it's present form.  Buildbot is on its way out anyways.

Comment 18

[Kim Moir [:kmoir] ET]

Comment on attachment 8842923 [details] [diff] [review]
bug_1342202_v4.patch

let's just land as is since buildbot is going away anyways

Comment 19

[Kim Moir [:kmoir] ET]

Sebastian, I reverted your patch because the tests failed.

https://travis-ci.org/mozilla-releng/build-buildbot-configs/builds/208623927

Comment 20

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1342202_v5.patch

Comment 21

[Sebastian Pacurar [:spacurar]]

Attachment: diff_v5

This is the diff compared to the diff file from the patch in production (bug_1342202_v3). On the v3 patch mochitest-a11y wasn't disabled on win 7 ix on try branch.

Comment 22

[Kim Moir [:kmoir] ET]

Comment on attachment 8844826 [details] [diff] [review]
bug_1342202_v5.patch

Why is the diff only for try now (I thought it was needed for other branches).  Also, running test-master.sh show green results?

Comment 23

[Sebastian Pacurar [:spacurar]]

It is the diff compared to the v3 patch. For instance if I revert to the revision before Alin landed the patch, the differences would look just like the diffs from version 3 patch plus those 2 lines about win 32 ix on try branches being disabled. Yes, test-master.sh showed only green OK's.