Closed Bug 1342215 Opened 6 years ago Closed 6 years ago

pageError stubs generation is incorrect

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

We set a listener for "pageError" but we don't remove them. 
There is a `once: true` propertyas an option for addListener, but this isn't a standard addEventListener call, and this the once property doesn't do anything.
Summary: pageError stubs generation is broken → pageError stubs generation is incorrect
Comment on attachment 8840592 [details]
Bug 1342215 - Fix pageError stub generation.

https://reviewboard.mozilla.org/r/115054/#review116638

good catch!
Attachment #8840592 - Flags: review?(jdescottes) → review+
Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/647cbb760050
Fix pageError stub generation. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/647cbb760050
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.