1342241 - handle errors when adding a new user better

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[[e-mail] (:bhearsum)]

Adding a new user is a bit weird in the frontend. First, you go through a small form that adds the user to the list in the frontend (but _doesn't_ change anything on the backend), and then you grant them a permission with the form that pops up. The problem is, if anything goes wrong after the user is added to the list, they stay in the list despite the fact that the backend knows nothing about them.

We also end up adding a new user to the list if you make an error in the first form (eg: not entering a username).

In any case where the user does not have a permission when the second dialog closes, the user should be removed from the list. This includes:
* Error when entering username in the first form
* Closing the second form without saving any changes
* Hitting an error when trying to save a change in the second form, and not fixing it before closing it.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/7a345d3a4b57a8922a470b92f9e835bf40869d62
Bug 1342241: Handle errors when adding a new user better (#306). r=bhearsum

Comment 2

[[e-mail] (:bhearsum)]

This is in production now, thank you!