Closed Bug 134225 Opened 24 years ago Closed 24 years ago

Update milestone for Mozilla 1.0 release

Categories

(SeaMonkey :: Build Config, defect, P1)

Product:
SeaMonkey
Component:
Build Config
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: lpham, Assigned: asasaki)

References

Details

Attachments

(2 files)

Patch to update milestone to 1.0.0+ on the trunk
395 bytes, text/plain
leaf
: superreview+
leaf
: approval+
Details
Patch to update milestone to 1.0.0 on MOZILLA_1_0_0_BRANCH
406 bytes, text/plain
leaf
: superreview+
leaf
: approval+
Details
Need two patches to update mozilla/config/milestone.txt One is for the trunk (1.0.0+) One is for MOZILLA_1_0_0_BRANCH (1.0.0) *This bug must do after releasing Mozilla 1.0 RC1
Keywords: mozilla1.0
must have. mozilla1.0+
Keywords: mozilla1.0 → mozilla1.0+
Severity: normal → blocker
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.0
Blocks: 136189
Need r/sr= for above patches
do we really want this to be 1.0.0 already? (this means dlls and exes will be versioned 1.0.0 in all daily branch builds, which might confuse things when we want to make sure it's *really* 1.0.0)
We need to land this bug for Mozilla 1.0 RC1. It is ok to land on MOZILLA_1_0_0_BRANCH and the trunk now. Need r= and sr= for your patch and check them in when the tree is open. a=leaf@mozilla.org Aki, the difference between RC1 and Mozilla 1.0 is About: page and UserAgent string.
right, but dll/exe version numbers tells gecko products if they can use the existing dlls/exes or if you need to upgrade, and bug fixes will go in between rc1 and 1.0... Basically, at this point it doesn't really matter what milestone.txt says as long as it has a + at the end (then it's ignored). Once it doesn't have a + at the end, official builds version the dlls and exes which we really only want for a real release, I think.
yes, we want 1.0.0. We have about 30 other things to worry about and RC1 is low on the list. Anyone who gets RC1 will almost definitely go to the final release, if not something even more recent, so it should be a small enough risk. We need to get all the 1.0.0 changes in the branch now and get RC1 out the door.
r=asasaki
Comment on attachment 78996 [details] Patch to update milestone to 1.0.0+ on the trunk sr, a=leaf
Attachment #78996 - Flags: superreview+
Attachment #78996 - Flags: approval+
Comment on attachment 79000 [details] Patch to update milestone to 1.0.0 on MOZILLA_1_0_0_BRANCH sr/a=leaf
Attachment #79000 - Flags: superreview+
Attachment #79000 - Flags: approval+
Checked into the branch and the trunk. Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I see the checkins, but when I look at the version information for the 1.0 dlls and the trunk dlls, I don't see any difference. Shouldn't the version for the files on the 1.0 branch be 1.0.0.buildid rather than 0.0.0.0?
that's correct... we should have a 1.0.0 version on the branch now. shame that we don't keep any old build logs lying around on seaquake (or i can't find them). will look into it.
reopening for further investigation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
reassign to asasaki.
Assignee: ycalonje → asasaki
Status: REOPENED → NEW
fix is in patch 79315 in bug 136673. can split up the patches if necessary.
Status: NEW → ASSIGNED
leaf checked the fix into the branch, so this should be fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified 20020416 on win2k
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: