Closed Bug 1342252 Opened 7 years ago Closed 7 years ago

reftest no longer prints screenshots for failures of != tests

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

The reftest harness no longer prints screenshots for test failures of != tests.  This is essential for debugging reftest-print test failures, since you can't just look at the tests in the browser, so the easiest way to view them is to swap != and == in the manifest and look at the failure image.

It's also useful for debugging != test failures in general.
Comment on attachment 8840641 [details]
Bug 1342252 - Fix printing of reftest images for failed != tests.

https://reviewboard.mozilla.org/r/115090/#review116664
Attachment #8840641 - Flags: review?(james) → review+
Pushed by dbaron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/281b088f98eb
Fix printing of reftest images for failed != tests.  r=jgraham
https://hg.mozilla.org/mozilla-central/rev/281b088f98eb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.