Closed
Bug 1342273
Opened 7 years ago
Closed 7 years ago
Improve frontend tracelogging
Categories
(Developer Documentation Graveyard :: JavaScript, defect)
Developer Documentation Graveyard
JavaScript
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: shu, Unassigned)
References
Details
Attachments
(1 file)
49.68 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
Attachment #8840680 -
Flags: review?(hv1989)
Reporter | ||
Comment 2•7 years ago
|
||
See also https://github.com/h4writer/tracelogger/pull/26
Comment 3•7 years ago
|
||
Comment on attachment 8840680 [details] [diff] [review] Improve frontend tracelogging. Review of attachment 8840680 [details] [diff] [review]: ----------------------------------------------------------------- Cool!
Comment 4•7 years ago
|
||
Comment on attachment 8840680 [details] [diff] [review] Improve frontend tracelogging. Review of attachment 8840680 [details] [diff] [review]: ----------------------------------------------------------------- Woops. Forgot to flip the switch
Attachment #8840680 -
Flags: review?(hv1989) → review+
Pushed by shu@rfrn.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc682c2db247 Improve frontend tracelogging. (r=h4writer)
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cc682c2db247
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 7•7 years ago
|
||
Either this bug or bug 1341061 regressed Octane-CodeLoad quite a bit (10%). It's probably this one. https://arewefastyet.com/#machine=29&view=single&suite=octane&subtest=CodeLoad&start=1487934027&end=1487997160 Could you take a look?
Flags: needinfo?(shu)
Reporter | ||
Comment 8•7 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #7) > Either this bug or bug 1341061 regressed Octane-CodeLoad quite a bit (10%). > It's probably this one. > > https://arewefastyet.com/ > #machine=29&view=single&suite=octane&subtest=CodeLoad&start=1487934027&end=14 > 87997160 > > Could you take a look? I didn't find any regressions locally. I did notice that default shell builds #define JS_TRACE_LOGGING 1. If tracelogging is on, I *do* reproduce a big regression in codeload. Could it be that AWFY is building default shells with tracelogging turned on?
Flags: needinfo?(shu) → needinfo?(hv1989)
Reporter | ||
Comment 9•7 years ago
|
||
We should also check if browser builds are compiling in tracelogging.
Comment 10•7 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #9) > We should also check if browser builds are compiling in tracelogging. They are :/ So our options are backing out, optimizing to zero-overhead (might be hard if we want more fine-grained tracelogging?), or adding another #ifdef. The merge is next week. Hannes, btw, do we really need TL enabled on beta/release?
Reporter | ||
Comment 11•7 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #10) > (In reply to Shu-yu Guo [:shu] from comment #9) > > We should also check if browser builds are compiling in tracelogging. > > They are :/ So our options are backing out, optimizing to zero-overhead > (might be hard if we want more fine-grained tracelogging?), or adding > another #ifdef. The merge is next week. > > Hannes, btw, do we really need TL enabled on beta/release? We should not compile with TL default on. It's such an internal JS engine dev feature.
Comment 12•7 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #8) > I did notice that default shell builds #define JS_TRACE_LOGGING 1. If > tracelogging is on, I *do* reproduce a big regression in codeload. Could it > be that AWFY is building default shells with tracelogging turned on? All builds have JS_TRACE_LOGGING enabled to 1. Even in that case the overhead should be not-detectable. One of the reasons is that there was a plan to use it in devtools. I.e. it had to work in release builds also.
Flags: needinfo?(hv1989)
You need to log in
before you can comment on or make changes to this bug.
Description
•