Closed Bug 1342276 Opened 7 years ago Closed 7 years ago

Enable display caret layers for webrender

Categories

(Core :: Graphics: WebRender, defect)

51 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file, 1 obsolete file)

Start using WR to paint caret items.
Comment on attachment 8840970 [details] [diff] [review]
Enable caret layers in WR

Review of attachment 8840970 [details] [diff] [review]:
-----------------------------------------------------------------

Why does this get rid of the border layer pref?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8840970 [details] [diff] [review]
> Enable caret layers in WR
> 
> Review of attachment 8840970 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why does this get rid of the border layer pref?

It was explicitly set to false when it didn't need to be since it's already default false in gfxPrefs.
(In reply to Mason Chang [:mchang] from comment #3)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> > Comment on attachment 8840970 [details] [diff] [review]
> > Enable caret layers in WR
> > 
> > Review of attachment 8840970 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Why does this get rid of the border layer pref?
> 
> It was explicitly set to false when it didn't need to be since it's already
> default false in gfxPrefs.

But having it all.prefs makes it show up in about:config which is more convenient.
Attachment #8840970 - Attachment is obsolete: true
Attachment #8840970 - Flags: review?(jmuizelaar)
Attachment #8840987 - Flags: review?(jmuizelaar)
Attachment #8840987 - Flags: review?(jmuizelaar) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/6237f9ee107b
Enable display caret layers for webrender. r=jmuizelaar
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.