Closed Bug 1342286 Opened 5 years ago Closed 5 years ago

Add "he", "ur", "ar" and "fa" locales to maemo-locale for multi-locale builds

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec53+, firefox53 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fennec 53+ ---
firefox53 --- fixed

People

(Reporter: delphine, Assigned: delphine)

Details

Attachments

(1 file)

bug1342286.patch
701 bytes, patch
flod
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Support for RTL should be in better shape with Firefox 53, so let's add all these RTL locales to multi-locale builds so they can ship as well :)
They've also been testing consistently on single-locale builds.
Attached patch bug1342286.patch — — Splinter Review
Attachment #8840693 - Flags: review?(francesco.lodolo)
Release Note Request (optional, but appreciated)
[Why is this notable]: New Locales
[Affects Firefox for Android]: yes
[Suggested wording]: Locales added: Arabic (ar), Hebrew (he), Persian (fa) and Urdu (ur)
[Links (documentation, blog post, etc)]:
tracking-fennec: --- → ?
Comment on attachment 8840693 [details] [diff] [review]
bug1342286.patch

Review of attachment 8840693 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #8840693 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8840693 [details] [diff] [review]
bug1342286.patch

Thanks flod! 
Request to land on Aurora only. 
Please see relnotes in comment 2. 

Stoked to get these RTL locales finally shipping :D
Attachment #8840693 - Flags: approval-mozilla-aurora?
Fantastic, should this have a release note or is this at the aurora-only testing stage?
Comment on attachment 8840693 [details] [diff] [review]
bug1342286.patch

Aurora-only uplift.
Attachment #8840693 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Fantastic, should this have a release note or is this at the aurora-only
> testing stage?

Yes, release notes are in comment 2 (did I tag that wrong?). Thanks :D
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #7)
> Yes, release notes are in comment 2 (did I tag that wrong?). Thanks :D

Good question. Do we use the relnotes-firefox flag for Fennec too?
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
tracking-fennec: ? → 53+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.