Closed
Bug 1342286
Opened 8 years ago
Closed 8 years ago
Add "he", "ur", "ar" and "fa" locales to maemo-locale for multi-locale builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec53+, firefox53 fixed)
RESOLVED
FIXED
People
(Reporter: delphine, Assigned: delphine)
Details
Attachments
(1 file)
701 bytes,
patch
|
flod
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Support for RTL should be in better shape with Firefox 53, so let's add all these RTL locales to multi-locale builds so they can ship as well :)
They've also been testing consistently on single-locale builds.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8840693 -
Flags: review?(francesco.lodolo)
Assignee | ||
Comment 2•8 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: New Locales
[Affects Firefox for Android]: yes
[Suggested wording]: Locales added: Arabic (ar), Hebrew (he), Persian (fa) and Urdu (ur)
[Links (documentation, blog post, etc)]:
tracking-fennec: --- → ?
Comment 3•8 years ago
|
||
Comment on attachment 8840693 [details] [diff] [review]
bug1342286.patch
Review of attachment 8840693 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #8840693 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8840693 [details] [diff] [review]
bug1342286.patch
Thanks flod!
Request to land on Aurora only.
Please see relnotes in comment 2.
Stoked to get these RTL locales finally shipping :D
Attachment #8840693 -
Flags: approval-mozilla-aurora?
Comment 5•8 years ago
|
||
Fantastic, should this have a release note or is this at the aurora-only testing stage?
Updated•8 years ago
|
status-firefox53:
--- → affected
Comment 6•8 years ago
|
||
Attachment #8840693 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Fantastic, should this have a release note or is this at the aurora-only
> testing stage?
Yes, release notes are in comment 2 (did I tag that wrong?). Thanks :D
Comment 8•8 years ago
|
||
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #7)
> Yes, release notes are in comment 2 (did I tag that wrong?). Thanks :D
Good question. Do we use the relnotes-firefox flag for Fennec too?
Comment 9•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
tracking-fennec: ? → 53+
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•