1342288 - Fennec should display the entire browser on Chromecast, not just web area

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[kyoohyun.kim]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 NetHelper70

Steps to reproduce:

Step1. I connected chromecast device with galaxy s7, google nexus and LG v20
Step2. Launch firefox browser and browsing any web-site
Step3. Rotate phone to landscape


Actual results:

Mirroring image is abnormal on chromecast device.


Expected results:

Mirroring image should be no problem like other browser.

Comment 1

[kyoohyun.kim]

Attachment: Firefox browser

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Looks like the address bar space is being sent to the remote device. Disabling Full-screen browsing in the general section of the Firefox settings may work around this issue.

Comment 3

[kyoohyun.kim]

Thank you for your kind comment.
I tried this after disabling "Full-screen browsing" in general tap but it's not work well.
I tested with below procedure.

1. Disabled "Full-screen browsing"
2. Kill fire-fox application.
3. Launch the fire-fox app.
==> It's OK.
4. Rotate the phone screen portrait to landscape
==> The symptom is reproduced.


thanks.
kyoohyun.kim

Comment 4

[kyoohyun.kim]

Attachment: Chrome browser

Comment 5

[kyoohyun.kim]

For your reference, I attached another image captured with chrome browser.
With chrome browser, mirroring image shown on TV is normal.
With firefox browser, mirroring image shown on TV is leaning to the upper on TV.

Thanks
kyoohyun.kim

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

By looking at this bug, kyoohyun.kim, are you using the Android system cast screen feature? Thanks

Comment 7

[kyoohyun.kim]

I connected to chromecast device with google chromecast application not cast screen feature(wifi display menu)
Thanks.

Comment 8

[kyoohyun.kim]

Attachment: Chrome browsee

Comment 9

[Mike Kaply [:mkaply]]

So near as I can tell, somehow we stop being able to cast "native" things to the screen. So URL bar doesn't display, keyboard doesn't display, about:home doesn't display. etc.

The web content still displays.

It's pretty easy to get yourself in this mode - just clicking the tab icon to add a tab causes us to enter this.

I'm at a loss as to why this would happen.

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

Clearing the NI as there is not something for me to answer in comment 5

Comment 11

[Mike Kaply [:mkaply]]

So the behavior you're seeing at this point is working as designed.

The current Firefox behavior is to attempt to show only the web content on the screen, not the entire UI.

I'm going to open a new bug to propose that we eliminate this behavior.

Comment 12

[kyoohyun.kim]

Thank you for your comment.
I hope Firefox acts like other browser.
Thanks

Comment 13

[Mike Kaply [:mkaply]]

Actually, I'm going to morph this bug.

Currently Fennec tries to only show the web content on the screen with a Chromecast. The problem with this approach is that the web view changes a lot. particular when keyboard are displayed and when the device is rotated.

It also means that the appearance on the television is that parts are missing.

We should behave the same way as Chrome and simply show the entire browser.

Comment 16

[Mike Kaply [:mkaply]]

I know I fiddled around with this locally on the advice of snorp. I'm hoping he can point me to the code again.

I vaguely remember you mentioning some place where we set the canvas (or something to that effect) for what we give to the chromecast.

Would you happen to remember? 

Frustratingly, I had a patch and never went anywhere with it.

Comment 17

[James Willcox (:snorp) ([e-mail]) (he/him)]

It's in PresentationMediaPlayerManager.java

We just need to nuke that whole file I think, and then Android will do the default thing and just show our entire app.

Comment 18

[Mike Kaply [:mkaply]]

Attachment: Bug 1342288 - Remove PresentationMediaPlayerManager.

Review commit: https://reviewboard.mozilla.org/r/225586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225586/

Comment 19

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8956630 [details]
Bug 1342288 - Remove PresentationMediaPlayerManager.

https://reviewboard.mozilla.org/r/225586/#review231458

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e8108c83a68
Remove PresentationMediaPlayerManager. r=snorp

Comment 21

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9e8108c83a68